Skip to content

Conversation

@shimon-armis
Copy link

@shimon-armis shimon-armis commented Sep 2, 2022

…t key

This PR is aims to FIX an issues with stored "variance" operation result:
It seems that the result is stored in the returned dict with the key "deviation" instead of "variance".
This PR fixes it.

Signed-off-by: shimon-armis shimon.turjeman@armis.com

…t key

Signed-off-by: shimon-armis <shimon.turjeman@armis.com>
@shimon-armis
Copy link
Author

Hey @4n4nd , Can u plz check this out?

Copy link
Collaborator

@chauhankaranraj chauhankaranraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

/lgtm :shipit:

@shimon-armis
Copy link
Author

@chauhankaranraj

  1. Can u maybe tell why didn't the PR check run?
  2. Who can merge this PR? (I don't see the "merge" button).

@shimon-armis
Copy link
Author

@chauhankaranraj

  1. Can u maybe tell why didn't the PR check run?
  2. Who can merge this PR? (I don't see the "merge" button).

@4n4nd Can u please review this PR and refer to the questions above?

@shimon-armis
Copy link
Author

@chauhankaranraj @4n4nd

@4n4nd
Copy link
Owner

4n4nd commented Sep 6, 2022

  1. Can u maybe tell why didn't the PR check run?

for first time contributors, we need to approve the tests that need to be run

  1. Who can merge this PR? (I don't see the "merge" button).

Only project maintainers/collaborators can merge a PR

Copy link
Owner

@4n4nd 4n4nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@4n4nd 4n4nd merged commit 63b4a76 into 4n4nd:master Sep 6, 2022
@shimon-armis
Copy link
Author

  1. Can u maybe tell why didn't the PR check run?

for first time contributors, we need to approve the tests that need to be run

  1. Who can merge this PR? (I don't see the "merge" button).

Only project maintainers/collaborators can merge a PR

Thanks @4n4nd !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants