Add get_label_values function in prometheus_connect.py. #235

lixir · 2021-12-26T02:07:40Z

Hello! You can add this function to be able to get a list of all values for a specific label.

sesheta · 2021-12-26T02:12:43Z

Pre-Commit Test failed! Click here

[INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pycqa/pydocstyle.git.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Initializing environment for https://github.com/psf/black.
[INFO] Initializing environment for https://gitlab.com/PyCQA/flake8.
[INFO] Initializing environment for https://gitlab.com/PyCQA/flake8:pep8-naming.
[INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pycqa/pydocstyle.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://gitlab.com/PyCQA/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Passed
Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for byte-order marker..............................................Passed
Check for case conflicts.................................................Passed
Check docstring is first.................................................Passed
Check JSON...............................................................Passed
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Check python ast.........................................................Passed
Debug Statements (Python)................................................Passed
pydocstyle...............................................................Passed
Check Toml...............................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
mypy.....................................................................Passed
black....................................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

prometheus_api_client/exceptions.py:4:8: N818 exception name 'PrometheusApiClientException' should be named with an Error suffix

sesheta · 2021-12-26T02:13:31Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign 4n4nd after the PR has been reviewed.
You can assign the PR to them by writing /assign @4n4nd in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chauhankaranraj

Hello, thanks for the contribution, this is great!

Just a thought, would it be a good idea to update the all_metrics function to use this functoin internally like so:

self.get_label_values(label_name="__name__")

/cc @4n4nd @lixir

sesheta · 2022-01-04T13:34:05Z

@chauhankaranraj: GitHub didn't allow me to request PR reviews from the following users: lixir.

Note that only AICoE members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Hello, thanks for the contribution, this is great!

Just a thought, would it be a good idea to update the all_metrics function to use this functoin internally like so:
self.get_label_values(label_name="__name__")
/cc @4n4nd @lixir

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sesheta · 2022-01-05T22:02:55Z

Pre-Commit Test failed! Click here

[INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pycqa/pydocstyle.git.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Initializing environment for https://github.com/psf/black.
[INFO] Initializing environment for https://gitlab.com/PyCQA/flake8.
[INFO] Initializing environment for https://gitlab.com/PyCQA/flake8:pep8-naming.
[INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pycqa/pydocstyle.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://gitlab.com/PyCQA/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Passed
Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for byte-order marker..............................................Passed
Check for case conflicts.................................................Passed
Check docstring is first.................................................Passed
Check JSON...............................................................Passed
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Check python ast.........................................................Passed
Debug Statements (Python)................................................Passed
pydocstyle...............................................................Passed
Check Toml...............................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
mypy.....................................................................Passed
black....................................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

prometheus_api_client/exceptions.py:4:8: N818 exception name 'PrometheusApiClientException' should be named with an Error suffix

lixir · 2022-01-05T22:05:54Z

Hi, @chauhankaranraj! Thanks, I replaced the duplicate code in aafd99b.

chauhankaranraj

Hi, @chauhankaranraj! Thanks, I replaced the duplicate code in aafd99b.

Awesome, thanks!
/lgtm

4n4nd

@lixir could you please add a small test for this function? (Example)

sesheta · 2022-01-09T04:39:50Z

New changes are detected. LGTM label has been removed.

sesheta · 2022-01-09T04:44:43Z

Pre-Commit Test failed! Click here

[INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pycqa/pydocstyle.git.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Initializing environment for https://github.com/psf/black.
[INFO] Initializing environment for https://gitlab.com/PyCQA/flake8.
[INFO] Initializing environment for https://gitlab.com/PyCQA/flake8:pep8-naming.
[INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pycqa/pydocstyle.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://gitlab.com/PyCQA/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Passed
Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
Check for byte-order marker..............................................Passed
Check for case conflicts.................................................Passed
Check docstring is first.................................................Passed
Check JSON...............................................................Passed
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
Check python ast.........................................................Passed
Debug Statements (Python)................................................Passed
pydocstyle...............................................................Passed
Check Toml...............................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
mypy.....................................................................Passed
black....................................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

prometheus_api_client/exceptions.py:4:8: N818 exception name 'PrometheusApiClientException' should be named with an Error suffix

lixir · 2022-01-09T04:45:46Z

Hi @4n4nd! I have added tests for get_label_values() in b64d90a.

lixir · 2022-01-09T04:52:15Z

tests/test_prometheus_connect.py

+        self.assertEqual(metrics_list, self.pc.get_label_values("__name__"))
+        # Check for the "job" label.
+        label_values = self.pc.get_label_values("job")
+        self.assertTrue(len(label_values) > 0, "no metrics received from prometheus")


Here I added a check for this label(job) for your test server (http://demo.robustperception.io:9090/). I am comparing the number of values to zero. If you need to compare the result with the current value and it will not change over time, I can make an edit.
Current value for "job" label: ['alertmanager', 'node', 'prometheus', 'pushgateway']

sesheta · 2022-04-13T07:11:59Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta · 2022-05-13T08:34:20Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

4n4nd · 2022-06-08T20:55:14Z

@lixir sorry for the delay in review. This PR look good 👍
Thanks for working on it!

Add get_label_values function in prometheus_connect.py.

08a69cc

sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 26, 2021

sesheta requested review from chauhankaranraj and hemajv December 26, 2021 02:11

chauhankaranraj requested changes Jan 4, 2022

View reviewed changes

sesheta requested a review from 4n4nd January 4, 2022 13:34

Improving the all_metrics function via get_label_values.

aafd99b

lixir requested a review from chauhankaranraj January 5, 2022 22:07

chauhankaranraj reviewed Jan 6, 2022

View reviewed changes

sesheta assigned chauhankaranraj Jan 6, 2022

sesheta added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022

4n4nd requested changes Jan 6, 2022

View reviewed changes

Added tests for get_label_values().

b64d90a

sesheta removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2022

sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2022

lixir commented Jan 9, 2022

View reviewed changes

lixir requested a review from 4n4nd January 13, 2022 06:26

sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 13, 2022

chauhankaranraj mentioned this pull request Apr 13, 2022

PEP8 violating class name PrometheusApiClientException #239

Open

sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 13, 2022

4n4nd closed this Jun 8, 2022

4n4nd reopened this Jun 8, 2022

4n4nd approved these changes Jun 8, 2022

View reviewed changes

4n4nd merged commit fa9436b into 4n4nd:master Jun 8, 2022

Uh oh!

Add get_label_values function in prometheus_connect.py. #235

Add get_label_values function in prometheus_connect.py. #235

Uh oh!

Conversation

lixir commented Dec 26, 2021

Uh oh!

sesheta commented Dec 26, 2021

Uh oh!

sesheta commented Dec 26, 2021

Uh oh!

chauhankaranraj left a comment

Choose a reason for hiding this comment

Uh oh!

sesheta commented Jan 4, 2022

Uh oh!

sesheta commented Jan 5, 2022

Uh oh!

lixir commented Jan 5, 2022

Uh oh!

chauhankaranraj left a comment

Choose a reason for hiding this comment

Uh oh!

4n4nd left a comment

Choose a reason for hiding this comment

Uh oh!

sesheta commented Jan 9, 2022

Uh oh!

sesheta commented Jan 9, 2022

Uh oh!

lixir commented Jan 9, 2022

Uh oh!

lixir Jan 9, 2022

Choose a reason for hiding this comment

Uh oh!

sesheta commented Apr 13, 2022

Uh oh!

sesheta commented May 13, 2022

Uh oh!

4n4nd commented Jun 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants