Snapshot Save Single Action #7500
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeylMahfouf2608
commented
Mar 24, 2025
NeylMahfouf2608
commented
Mar 24, 2025
4ian
reviewed
Mar 25, 2025
4ian
reviewed
Mar 25, 2025
4ian
reviewed
Mar 25, 2025
4ian
reviewed
Mar 25, 2025
4ian
reviewed
Mar 25, 2025
4ian
reviewed
Mar 25, 2025
Extensions/Physics3DBehavior/PhysicsCharacter3DRuntimeBehavior.ts
Outdated
Show resolved
Hide resolved
Extensions/Physics3DBehavior/PhysicsCharacter3DRuntimeBehavior.ts
Outdated
Show resolved
Hide resolved
Extensions/Physics3DBehavior/PhysicsCharacter3DRuntimeBehavior.ts
Outdated
Show resolved
Hide resolved
Extensions/TopDownMovementBehavior/topdownmovementruntimebehavior.ts
Outdated
Show resolved
Hide resolved
NeylMahfouf2608
commented
Apr 17, 2025
GDJS/Runtime/runtimescene.ts
Outdated
| this._loadStorageName = storageName; | ||
| } | ||
| if (sceneVar) { | ||
| this._loadVariable = sceneVar; |
There was a problem hiding this comment.
are those values cleared the next time we use the function without the sceneVar and storageName?
If not, I think we should always set the value from what's coming from the props of the function.
This will allow setting undefined or whatever string/variable is passed
AlexandreSi
reviewed
Apr 18, 2025
GDJS/Runtime/runtimescene.ts
Outdated
| @@ -650,6 +662,10 @@ namespace gdjs { | |||
| return this._cachedGameResolutionHeight / 2; | |||
| } | |||
|
|
|||
| getIsLoadingRequest() { | |||
There was a problem hiding this comment.
Should be named getIsLoadingRequested for consistency purposes
There was a problem hiding this comment.
Or just isLoadingRequested
…to step function of scenestack, switch from browser localstorage to indexedDB
…added some constants in separated files for clarity
…ndexedDB.ts functions
…unctions, renamed functions for clarity
…ransmission for volume in audiomanager, added syncOptions for all getNetworkSyncData.
AlexandreSi
force-pushed
the
snapshot-save-single-action
branch
from
f65e7ec to
31d9ff4
Compare
AlexandreSi
force-pushed
the
snapshot-save-single-action
branch
from
32fdbd2 to
03dec17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save and/or load the whole game using the updateFromNetworkSyncData/getNetworkSyncData methods to write/read a complete JSON. Done in one action for each (at the moment, might change). Right now it writes both on a localFile and localStorage of the browser.