Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating hash file names using [file name].[hash].[file ext] can potentially cause buster to hash the file name twice #14

Closed
jeffschwartz opened this issue Sep 16, 2019 · 0 comments
Closed

Creating hash file names using [file name].[hash].[file ext] can potentially cause buster to hash the file name twice #14

jeffschwartz opened this issue Sep 16, 2019 · 0 comments
Assignees
@jeffschwartz
Labels
bug Something isn't working
Milestone
v0.3.0

Comments

@jeffschwartz
Copy link
Collaborator

When hashing file names using [file name].[hash].[file ext] it is possible that trailing characters of the hash + file ext can match a real file and the result will be [file name].[hash].[hash].[file ext] which is problematic.

To fix this, use [hash]-[file name].[file ext] instead when hashing files names.
@jeffschwartz jeffschwartz added the bug Something isn't working label Sep 16, 2019
@jeffschwartz jeffschwartz added this to the v0.2.5 milestone Sep 16, 2019
@jeffschwartz jeffschwartz self-assigned this Sep 16, 2019
jeffschwartz added a commit that referenced this issue Sep 16, 2019
@jeffschwartz
removed replace-in-file package,
abc4066 
updated package dependencies,
now using new format when creating hashed file names,
implemented replacement for replace-in-file,
reduced console.log output,
see issues #14, #15 & #16
@jeffschwartz jeffschwartz reopened this Sep 16, 2019
@jeffschwartz jeffschwartz changed the title Creating hash file names using [file name].[hash].[file ext] can potentially cause buster to hash the file twice Creating hash file names using [file name].[hash].[file ext] can potentially cause buster to hash the file name twice Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffschwartz jeffschwartz

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@jeffschwartz