Skip to content

Add macos arm wheels #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Czaki merged 5 commits into from
Feb 1, 2024
Merged

Add macos arm wheels #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d10ea2c
add macos arm wheels
Czaki Jan 30, 2024
ec9086c
bump cibuildwheel
Czaki Jan 31, 2024
e4dceef
Merge branch 'master' into macos_arm_wheel
Czaki Jan 31, 2024
b1b2182
build libomp
Czaki Jan 31, 2024
f6779a5
add sudo
Czaki Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,20 +49,18 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
os: [ubuntu-latest, windows-latest, macos-latest, macos-14]

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0

- if: runner.os == 'macOS'
run: brew install openblas
run: sudo bash build_utils/build_libomp.sh

- name: Build wheels
uses: pypa/cibuildwheel@v2.16.5
env:
OPENBLAS: "$(brew --prefix openblas)"

- uses: actions/upload-artifact@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion build_utils/build_libomp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
build_dir=${DIR}/libs_build

git clone --depth 1 --branch llvmorg-11.1.0 https://github.com/llvm/llvm-project
git clone --depth 1 --branch llvmorg-17.0.6 https://github.com/llvm/llvm-project
pushd llvm-project/openmp
mkdir build
cd build
Comment on lines 2 to 8
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [5-14]

Consider adding error handling for the commands used in this script. For instance, checking the exit status of git clone, cmake, and make commands can prevent proceeding with the script when an error occurs, enhancing the robustness of the build process.

+ set -e

Adding set -e at the beginning of the script will cause the script to exit immediately if a command exits with a non-zero status.

📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [5-14]

It's good practice to check if the required tools (git, cmake, clang, make) are available before proceeding with the build process. This can be done by adding simple checks at the beginning of the script.

+ command -v git >/dev/null 2>&1 || { echo >&2 "git is required but it's not installed.  Aborting."; exit 1; }
+ command -v cmake >/dev/null 2>&1 || { echo >&2 "cmake is required but it's not installed.  Aborting."; exit 1; }
+ command -v clang >/dev/null 2>&1 || { echo >&2 "clang is required but it's not installed.  Aborting."; exit 1; }
+ command -v make >/dev/null 2>&1 || { echo >&2 "make is required but it's not installed.  Aborting."; exit 1; }

Adding these checks ensures that the script only proceeds if all necessary tools are installed, preventing potential build failures and providing clear error messages to the user.

Expand Down