Skip to content

Conversation

@Czaki
Copy link
Collaborator

@Czaki Czaki commented Mar 10, 2025

closes #1224
closes #1238

As ipykernel==7.0.0a1 crash the --pre tests, then block it.

Summary by Sourcery

Build:

  • Blocks ipykernel version 7.0.0a1 in the pre_test_problematic_version.txt file.

Summary by CodeRabbit

  • Chores
    • Updated internal versioning to reflect the latest release.
    • Enhanced dependency management by expanding compatibility constraints for a key package.

@Czaki Czaki added this to the 0.16.1 milestone Mar 10, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 10, 2025

Reviewer's Guide by Sourcery

This pull request blocks the ipykernel==7.0.0a1 version in the pre_test_problematic_version.txt file. This was done because this version causes crashes during --pre tests.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Blocked ipykernel==7.0.0a1 to prevent crashes in --pre tests.
  • Added ipykernel==7.0.0a1 to the list of blocked versions.
requirements/pre_test_problematic_version.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2025

Walkthrough

This pull request updates configuration and dependency files. In the project definition file, the version number for the personal_ws entry is updated from 16 to 17, and an entry for ipykernel is added. Additionally, in the requirements file, the version constraints for ipykernel are expanded to exclude both version 7.0.0a0 and 7.0.0a1.

Changes

File Change Summary
.github/project_dict.pws Updated personal_ws version from 16 to 17; added ipykernel project entry.
requirements/pre_test_problematic_version.txt Modified ipykernel exclusion constraint to exclude both 7.0.0a0 and 7.0.0a1.

Possibly related PRs

Poem

I'm a rabbit, leaping through the code so bright,
Hopping from version 16 to 17 in plain sight.
I added ipykernel with a twitch and cheer,
Tightened constraints to keep troubles clear.
With joyful hops, I celebrate this new light!
🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0664154 and 9694f6b.

📒 Files selected for processing (2)
  • .github/project_dict.pws (2 hunks)
  • requirements/pre_test_problematic_version.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (21)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller windows)
  • GitHub Check: 4DNucleome.PartSeg (Tests_other test windows)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos_arm)
  • GitHub Check: 4DNucleome.PartSeg (Builds sdist)
  • GitHub Check: 4DNucleome.PartSeg (Tests_other test macos)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos)
  • GitHub Check: 4DNucleome.PartSeg (Tests_linux test_linux)
  • GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller_linux)
  • GitHub Check: Base py3.11 / windows-latest py 3.11 latest PyQt5
  • GitHub Check: Base py3.11 / macos-13 py 3.11 latest PyQt5
  • GitHub Check: Base py3.10 / ubuntu-20.04 py 3.10 latest PySide2
  • GitHub Check: Test PartSeg conda
  • GitHub Check: ubuntu-24.04 py3.12 --pre
  • GitHub Check: macos-14 py3.12 --pre
  • GitHub Check: windows-2022 py3.12 --pre
  • GitHub Check: 4DNucleome.PartSeg (manifest_check manifest_check)
  • GitHub Check: 4DNucleome.PartSeg (Documentation_check Notebook_check)
  • GitHub Check: 4DNucleome.PartSeg (formatting_check check_formating)
  • GitHub Check: 4DNucleome.PartSeg (GetTestData linux)
  • GitHub Check: 4DNucleome.PartSeg (Documentation_check help)
🔇 Additional comments (3)
.github/project_dict.pws (2)

1-1: Version number increment looks good.

The increment from 16 to 17 properly reflects the addition of a new word to the dictionary.


18-18: Addition of ipykernel to the project dictionary is appropriate.

Adding "ipykernel" to the dictionary ensures it won't be flagged as a spelling error in documentation or comments, which aligns with the package being referenced in the requirements file.

requirements/pre_test_problematic_version.txt (1)

2-2: Correctly blocks the problematic ipykernel version.

This change effectively blocks ipykernel version 7.0.0a1 which was causing crashes during the --pre tests, as mentioned in the PR objectives. The syntax for excluding multiple versions is properly formatted using comma separation.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Czaki - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why this version is blocked.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sonarqubecloud
Copy link

@Czaki Czaki changed the title Block ipykernel 7.0.0a1 ci: Block ipykernel 7.0.0a1 Mar 10, 2025
@Czaki Czaki merged commit ad259a0 into develop Mar 10, 2025
63 of 64 checks passed
@Czaki Czaki deleted the block_ipykernel branch March 10, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test-bot] pyinstaller bundle --pre is failing [test-bot] pip install --pre is failing

1 participant