Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge devel into main #319

Merged
merged 25 commits into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
8363660
Update pkgdown.yaml
mnky9800n Mar 20, 2024
8a3c96c
Update plot_mapping.R
aabelean Mar 21, 2024
85808ba
Update CHANGELOG.md
aabelean Mar 21, 2024
71e497a
xmatrix source build
mnky9800n Mar 21, 2024
6afa86c
Merge pull request #310 from 4DModeller/306-hydro-tutorial-doesnt-plo…
mnky9800n Mar 21, 2024
6f0076f
Added a check if output only contains random fields
aabelean Mar 30, 2024
378c8d5
Finn added this to inlabru test workflow (https://github.com/inlabru-…
aabelean Mar 30, 2024
4711201
Revert addition of package installation
aabelean Mar 30, 2024
1280863
Modify standard check
aabelean Mar 30, 2024
09d0695
Updated CHANGELOG.md
aabelean Mar 30, 2024
d1e00e6
Update CHANGELOG.md
aabelean Mar 30, 2024
27322e0
Merge pull request #317 from 4DModeller/Iss315/fix_model_viewer
mnky9800n May 15, 2024
42539a3
Merge pull request #256 from icetianli/main
mnky9800n May 23, 2024
d1b026f
Update references.bib
aabelean Jun 28, 2024
87aa348
Adding the reference formatting file
aabelean Jun 29, 2024
f0fdf19
Add the OHC tutorial
aabelean Jun 29, 2024
e5a7e70
Update CHANGELOG.md
aabelean Jun 29, 2024
3e19124
Update _pkgdown.yml
aabelean Jun 29, 2024
cec8c9f
Update CHANGELOG.md
aabelean Jun 29, 2024
11e5d34
Update references.bib
aabelean Jun 29, 2024
df7e974
Disable map plots for ohc_tutorial.Rmd
aabelean Jun 29, 2024
c6d8c0b
Include warnings in ohc_tutorial.Rmd
aabelean Jun 29, 2024
b7db45f
Update ohc_tutorial.Rmd
aabelean Jun 29, 2024
398852b
Merge pull request #318 from 4DModeller/tutorialOHC
mnky9800n Jul 11, 2024
57732d4
Update pkgdown.yaml
aabelean Jul 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/check-standard.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ jobs:
with:
extra-packages: any::rcmdcheck
needs: check
- name: Fix temporary out-of-sync binary packages
run: |
install.packages("MatrixModels", repos = "https://cloud.r-project.org", type = "source")
shell: Rscript {0}
- uses: r-lib/actions/check-r-package@v2
with:
upload-snapshots: true
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/pkgdown.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ jobs:
any::bookdown
local::.
needs: website
- name: Fix temporary out-of-sync binary packages
run: |
install.packages("MatrixModels", repos = "https://cloud.r-project.org", type = "source")
shell: Rscript {0}
- name: Build site
run: pkgdown::build_site_github_pages(new_process = FALSE, install = FALSE)
shell: Rscript {0}
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased](https://github.com/openghg/openghg/compare/0.2.0...HEAD)

### Fixed

- Fixed `model_viewer` app to work with random effect models - [PR #317](https://github.com/4DModeller/fdmr/pull/317)
- Updated `plot_map_leaflet` to feature the same selection of basemap tiles as `mapview` and fix features not appearing - [PR #310](https://github.com/4DModeller/fdmr/pull/310)

### Added
- Added ocean heat content mapping tutorial - [PR #318](https://github.com/4DModeller/fdmr/pull/318)

## [0.2.0] - 2023-12-19

### Fixed
Expand Down
5 changes: 3 additions & 2 deletions R/plot_mapping.R
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ plot_map_leaflet <- function(polygon_data = NULL,
wrapping = FALSE) {
m <- leaflet::leaflet()
m <- leaflet::addTiles(m)
m <- leaflet::addProviderTiles(m, leaflet::providers$Openstreetmap, group = "Satellite")
m <- leaflet::addProviderTiles(m, leaflet::providers$Esri.WorldImagery, group = "Satellite")
m <- leaflet::addProviderTiles(m, leaflet::providers$OpenTopoMap, group = "Topography")
m <- leafem::addMouseCoordinates(m, native.crs = TRUE)

# Store a vector of layers we add to the map,
Expand Down Expand Up @@ -161,7 +162,7 @@ plot_map_leaflet <- function(polygon_data = NULL,

m <- leaflet::addLayersControl(m,
position = "topright",
baseGroups = c("OSM", "Satellite"),
baseGroups = c("OSM", "Satellite", "Topography"),
overlayGroups = layers,
options = leaflet::layersControlOptions(collapsed = FALSE)
)
Expand Down
7 changes: 6 additions & 1 deletion R/shiny_modelviewer.R
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ model_viewer_shiny <- function(model_output, mesh, measurement_data, data_distri
default_colours <- rownames(brewer_palettes[brewer_palettes$cat == "seq", ])

plot_choices <- c("Range", "Stdev", "AR(1)", "Boxplot", "Density", "DIC")
if (base::is.null(parsed_model_output[["fixed_mean"]])) {
map_choices <- c("Random effect fields")
} else {
map_choices <- c("Predicted mean fields", "Random effect fields")
}

ui <- bslib::page_fluid(
theme = bslib::bs_theme(bootswatch = "cosmo"),
Expand All @@ -56,7 +61,7 @@ model_viewer_shiny <- function(model_output, mesh, measurement_data, data_distri
shiny::fluidRow(
shiny::column(
4,
shiny::selectInput(inputId = "map_plot_type", label = "Plot type", choices = c("Predicted mean fields", "Random effect fields"), selected = "Predicted mean fields"),
shiny::selectInput(inputId = "map_plot_type", label = "Plot type", choices = map_choices, selected = map_choices[1]),
shiny::selectInput(inputId = "map_data_type", label = "Data type", choices = c("Poisson", "Gaussian"), selected = data_distribution),
),
shiny::column(
Expand Down
2 changes: 2 additions & 0 deletions _pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ navbar:
href: articles/hydro.html
- text: "Priors exploration"
href: articles/priors.html
- text: "Ocean heat content mapping"
href: articles/ohc_tutorial.html
- text: ---
- text: "FAQ"
- text: INLA Crash FAQ
Expand Down
Loading
Loading