-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Antimeridian problem #285
Antimeridian problem #285
Conversation
Adds converter from 0/360 to -180/180 and a function that splits the polygon along the dateline
Added support for antimeridian wrapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aabelean. Both plot_mapping.R and plot_mesh.R work ok, but shiny_meshbuilder.R returns an error when testing it with the covid19 data. The error is attached below.
I wonder if it now works. Tests seem to fail because the functions do not yet appear in NAMESPACE.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aabelean, the argument "map" is missing now in the function leaflet::addMeasure()
in shiny_meshbuilder.R. Once fixing it as m <- leaflet::addMeasure(m, position = 'bottomleft', primaryLengthUnit = 'kilometers', primaryAreaUnit = 'sqmeters')
, it works.
Thanks for checking, @XueqingYin . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks.
Added package `sfheaders`
Summary of changes (Bug fix, feature, docs update, ...)
Solves the antimeridian problem in mapping: split all polygons that cross the dateline/antimeridian. Added this function as optional for
plot_map
because the user-defined polygons might be too complex and cause errors.Please check if the PR fulfills these requirements
styler
run over codeCHANGELOG.md
file if fixing a bug or adding a new featureDESCRIPTION