Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a table to summarize the expected data format #140

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Add a table to summarize the expected data format #140

merged 1 commit into from
Sep 28, 2023

Conversation

XueqingYin
Copy link
Contributor

@XueqingYin XueqingYin commented Sep 27, 2023 •
edited
Loading

  • Summary of changes (Bug fix, feature, docs update, ...)
    This is to add a table to the data preprocessing tutorial to summarize the expected data format for running BHM in fdmr.

  • Please check if the PR fulfills these requirements

@XueqingYin
Add a table to summarize the expected data format
e2cd835 
Add a table to the tutorial to summarize the expected data format for running BHM in fdmr.
@XueqingYin XueqingYin added the documentation Improvements or additions to documentation label Sep 28, 2023
mnky9800n
mnky9800n approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@mnky9800n mnky9800n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good.

personally i would put made up data in the first two rows then ellipsis (...) in the third row. but that is stylistic choice.

@mnky9800n mnky9800n merged commit 81bb434 into main Sep 28, 2023
3 checks passed
@mnky9800n mnky9800n deleted the Iss133/DataPreprocess branch September 28, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnky9800n mnky9800n mnky9800n approved these changes

@gareth-j gareth-j Awaiting requested review from gareth-j

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data_preprocessing needs a clean graphic to summarize
2 participants
@XueqingYin @mnky9800n