Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model decisions #125

Merged
merged 9 commits into from
Sep 29, 2023
Merged

Model decisions #125

merged 9 commits into from
Sep 29, 2023

Conversation

mnky9800n
Copy link
Contributor

  • Summary of changes (Bug fix, feature, docs update, ...)
    creates tutorial page that describes where and when you should use fixed or random effects

  • Please check if the PR fulfills these requirements

  • Closes Decision tree for modelling decisions #113
  • Tests added and passed
  • All code checks passing - styler run over code
  • Vignettes updated/added
  • Added an entry in the latest CHANGELOG.md file if fixing a bug or adding a new feature
  • Any new libraries added to DESCRIPTION

@mnky9800n mnky9800n added documentation Improvements or additions to documentation high-priority labels Sep 22, 2023
@mnky9800n mnky9800n added this to the End to end tutorials milestone Sep 22, 2023
Copy link
Contributor

@XueqingYin XueqingYin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mnky9800n . In the YAML headers, the entry under %\VignetteIndexEntry{ } should be updated, replacing "Priors exploration". Additionally, it seems that how to obtain the DIC values for each model is missing in the section ### Comparing the output. Other than these, everything looks good to me.

Xueqing

@mnky9800n
Copy link
Contributor Author

mnky9800n commented Sep 22, 2023 via email

@XueqingYin
Copy link
Contributor

"decision tree diagram" is fine. And I agree with your second point.

Xueqing

@mnky9800n
Copy link
Contributor Author

Thanks @mnky9800n . In the YAML headers, the entry under %\VignetteIndexEntry{ } should be updated, replacing "Priors exploration". Additionally, it seems that how to obtain the DIC values for each model is missing in the section ### Comparing the output. Other than these, everything looks good to me.

Xueqing

i was going to use all of the different methods that @gareth-j will implement in the model evaluation tool. that's why i didn't do it yet.

@gareth-j gareth-j changed the title Modeldecisions Model decisions Sep 28, 2023
@mnky9800n mnky9800n merged commit 56bfdaa into main Sep 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation high-priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decision tree for modelling decisions
3 participants