various improvements to attachment bridging #2172
Conversation
previously, the urls were just appended to the message content. i couldn't find any other assignments directly to Extra["file"] anywhere in the codebase, so maybe there's a better way to do this.
many clients will only display files inline if the message body itself exactly matches the attachment URL. see https://docs.modernxmpp.org/client/protocol/#communicating-the-url
previously, the code assumed each file had a Data, and crashed if this was not present. now, we detect this condition, and send the URL instead. the discord client will display URLs in a message of their own as inline embeds, without any special behavior needed on our part. this commit makes the same changes to the webhook and non-webhook code.
|
Code Climate has analyzed commit ce93d90 and detected 0 issues on this pull request. View more on Code Climate. |
|
Im thinking of merging this to my fork. https://github.com/bibanon/matterbridge/ Has your commits still been working for you today? |
|
re the xmmp commit: for Conversation and Dino it works, I had initially the directory permissions for the media server wrong |
hi! yes, i'm still using these in my own private fork today. do you know if there's a maintained fork of matterbridge nowadays? i could find both bibanon/matterbridge and matterbridge-org/matterbridge |
* Update dependencies * Fix whatsmeow API changes
This prevents UnrealIRCd from sending message history unprompted when joining a channel, which can otherwise lead to messages getting bridged multiple times. See: https://www.unrealircd.org/docs/FAQ#History_mode_.28.2BH.29_causes_my_bot_to_re-trigger_previous_commands_-_What_do_I_do.3F
|
Please consider submitting some of these improvements as individual PRs to matterbridge-org/matterbridge which is the best maintained fork right now. |
5 participants
briefly:
Extra["file"]please see the full commit messages for more detail.