Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a option --use-gitignore, for parsing only source files not match to .gitignore #417

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Add a option --use-gitignore, for parsing only source files not match to .gitignore #417

merged 1 commit into from
Aug 10, 2023

Conversation

kiokuless
Copy link
Contributor

@kiokuless kiokuless commented Jul 30, 2023 •
edited
Loading

Closes #416

@kiokuless kiokuless changed the title Add option for support gitignore Add a option -g, for parsing only source files not match to .gitignore Jul 30, 2023
@kiokuless kiokuless force-pushed the add-option-for-support-gitignore branch 2 times, most recently from 5f64141 to bb7e730 Compare August 1, 2023 12:07
@kiokuless kiokuless changed the title Add a option -g, for parsing only source files not match to .gitignore Add a option --use-gitignore, for parsing only source files not match to .gitignore Aug 1, 2023
@kiokuless kiokuless force-pushed the add-option-for-support-gitignore branch from bb7e730 to 3e1b78e Compare August 1, 2023 15:54
@kiokuless kiokuless marked this pull request as ready for review August 1, 2023 15:56
@matthieu42Network
Copy link
Contributor

Hello as you can see here we want the code pushed to be flake8 compliant. Can you please correct the errors?

@kiokuless kiokuless force-pushed the add-option-for-support-gitignore branch from b4c9b55 to 3404987 Compare August 9, 2023 16:39
@kiokuless
Copy link
Contributor Author

Hello, I fixed it and I ran $ poetry run flake8 and $ poetry run pytest at my local laptop and it passed. I'll look at them properly before pushing from now on, thanks for the help.

matthieu42Network
matthieu42Network approved these changes Aug 10, 2023
View reviewed changes
norminette/__main__.py Outdated Show resolved Hide resolved
norminette/__main__.py Outdated Show resolved Hide resolved
norminette/__main__.py Outdated Show resolved Hide resolved
@matthieu42Network matthieu42Network merged commit af5bf14 into 42School:master Aug 10, 2023
@kiokuless
Copy link
Contributor Author

@matthieu42Network Thanks for your review!

@kiokuless kiokuless deleted the add-option-for-support-gitignore branch August 10, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu42Network matthieu42Network matthieu42Network approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Option to work with .gitignore to perform parsing on files that don't match.
2 participants
@kiokuless @matthieu42Network