fix: #75 - moved react and react-dom to devDependency #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed other version with 'npm audit fix'
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 2 2
Lines 142 142
Branches 39 39
=======================================
Hits 137 137
Misses 5 5Continue to review full report at Codecov.
|
Author
|
@40818419 can you please look into this pull request? faster response is much appreciated... |
Contributor
|
Why in dev-dependencies, they must be in the peer dependencies. |
|
should put them in both dev and peer dependencies so consumers will be aware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and running 'npm audit fix' updated the other npm dependencies to fix the vulnerabilities.
This PR fixes #75