-
Notifications
You must be signed in to change notification settings - Fork 221
Open
Description
Laravel Impersonate does not work with Laravel Octane. This manifests as several different errors concerning the $app
container missing expected values when impersonating and leaving impersonation, from both the ImpersonateManager
and ImpersonateController
.
I'm seeing two points where this is an issue:
- The singleton in the
ImpersonateServiceProvider
has the app container passed to the constructor. This doesn't work in the Octane paradigm -- the container is adjusted for every request, so a fresh copy is needed.- I'm not sure if the singleton is strictly needed? I've worked around this by extending the service provider and reimplementing
register()
without that.
- I'm not sure if the singleton is strictly needed? I've worked around this by extending the service provider and reimplementing
- The constructor in
ImpersonateController
sets themanager
property. It seems like the constructors for controllers are only called once when Octane boots, which is leading to the app container inside that manager instance being stale.- Injecting it into the take/leave methods individually instead of setting it in the constructor should avoid the issue.
If you are open to a PR, I would be happy to send one.
Sky-Cat
Metadata
Metadata
Assignees
Labels
No labels