Skip to content

Laravel Octane support #164

@nie7321

Description

@nie7321

Laravel Impersonate does not work with Laravel Octane. This manifests as several different errors concerning the $app container missing expected values when impersonating and leaving impersonation, from both the ImpersonateManager and ImpersonateController.

I'm seeing two points where this is an issue:

  1. The singleton in the ImpersonateServiceProvider has the app container passed to the constructor. This doesn't work in the Octane paradigm -- the container is adjusted for every request, so a fresh copy is needed.
    • I'm not sure if the singleton is strictly needed? I've worked around this by extending the service provider and reimplementing register() without that.
  2. The constructor in ImpersonateController sets the manager property. It seems like the constructors for controllers are only called once when Octane boots, which is leading to the app container inside that manager instance being stale.
    • Injecting it into the take/leave methods individually instead of setting it in the constructor should avoid the issue.

If you are open to a PR, I would be happy to send one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions