support for php 8.4

404labfr · Nov 26, 2024 · 6bee5c3 · 6bee5c3
1 parent 82cad73
commit 6bee5c3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: [8.3, 8.2, 8.1]
+        php: [8.4, 8.3, 8.2, 8.1]
         laravel: ["^11.0", "^10.0", "^9.0", "^8.12"]
         dependency-version: [prefer-lowest, prefer-stable]
         include:

diff --git a/src/helpers.php b/src/helpers.php
@@ -10,7 +10,7 @@
 	 * @param  null  $guard
 	 * @return bool
 	 */
-	function can_impersonate(string $guard = null): bool
+	function can_impersonate(?string $guard = null): bool
 	{
 		$guard = $guard ?? app('impersonate')->getCurrentAuthGuardName();
 
@@ -28,7 +28,7 @@ function can_impersonate(string $guard = null): bool
 	 * @param  string|null      $guard
 	 * @return bool
 	 */
-		function can_be_impersonated(Authenticatable $user, string $guard = null): bool
+		function can_be_impersonated(Authenticatable $user, ?string $guard = null): bool
 	{
 		$guard = $guard ?? app('impersonate')->getCurrentAuthGuardName();
 		return app('auth')->guard($guard)->check()
@@ -45,7 +45,7 @@ function can_be_impersonated(Authenticatable $user, string $guard = null): bool
 	 * @param  string|null  $guard
 	 * @return bool
 	 */
-	function is_impersonating(string $guard = null): bool
+	function is_impersonating(?string $guard = null): bool
 	{
 		$guard = $guard ?? app('impersonate')->getCurrentAuthGuardName();