fix(get-terraform-dir): Resolve incorrect job summary step being run #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform directory summary was running, even when terraform changes had not been made. The condition has been changed to use check for a non zero value in `all_changed_files_count`.
james3ware
approved these changes
Aug 30, 2024
3ware-release bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
## [3.1.3](v3.1.2...v3.1.3) (2024-08-30) ### Bug Fixes * **get-terraform-dir:** Resolve incorrect job summary step being run ([#103](#103)) ([f261ac4](f261ac4))
|
This PR is included in version 3.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream workflows were displaying the job summary for changed terraform files, when terraform files had not been changed.
The summary step conditional expressions have been updated to check a different output value to resolve this.
Tested upstream with terraform and non terraform changes.