-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Service Discovery Errors (AKA improve New API form) #1015
Improve Service Discovery Errors (AKA improve New API form) #1015
Conversation
9c02582
to
113e14e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
=========================================
+ Coverage 92.77% 92.97% +0.2%
=========================================
Files 2403 2417 +14
Lines 78544 79561 +1017
=========================================
+ Hits 72866 73974 +1108
+ Misses 5678 5587 -91
Continue to review full report at Codecov.
|
app/controllers/provider/admin/service_discovery/cluster_projects_controller.rb
Outdated
Show resolved
Hide resolved
app/javascript/src/NewService/components/FormElements/ServiceDiscoveryListItems.jsx
Outdated
Show resolved
Hide resolved
03ded4b
to
6259a45
Compare
6259a45
to
10d4ac9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅
What this PR does / why we need it:
Possible TODOs
Which issue(s) this PR fixes
THREESCALE-2646: Service Discovery: Improve error messages and visual feedback when ajax request fails
Verification steps
Having Service Discovery enabled and logged in in Openshift go to
/apiconfig/services/new
and select Import from Openshift. Mess around the form and look for any errors.Visuals
Expected:
When empty:
When error: