Skip to content

Ensure AddressSet tests close temporary files on Windows #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ensure AddressSet tests close temporary files on Windows #653

wants to merge 4 commits into from
+52 −29

Conversation

3rdIteration
Copy link
Owner

Summary

  • ensure the AddressSet file-based tests reopen temporary files by path so handles are closed before reuse
  • explicitly close and clean up temporary files opened with NamedTemporaryFile to avoid Windows locking

Testing

  • python run-all-tests.py

https://chatgpt.com/codex/tasks/task_e_68e3172e4e808322b48c266f60afcf1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@3rdIteration