Improve clipping performance #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doesn't work yet -- tiles added later are not clipped
still can improve -- next let's make use of mesh instead of traversing through entirety
instead of traversing over all of them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of a new event that is emitted from 3dtiles loader "contentPostProcess" after this modification:
3DStreet/aframe-loader-3dtiles-component@339b735#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346
Although most of the performance issues are the 3dtiles themselves regardless of clipping... That's a whole 'nother thing