Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add osm3d map type #741

Merged
merged 8 commits into from
Aug 15, 2024
Merged

add osm3d map type #741

merged 8 commits into from
Aug 15, 2024

Conversation

kfarr
Copy link
Collaborator

@kfarr kfarr commented Jul 29, 2024

things to do before making this available

  • - better handle 3 dependencies of osm-tiles, osm-geojson, and osm2geojson, right now they're all stuffed into osm-tiles-geojson.js (now using webpack on this fork: https://github.com/3DStreet/osm4vr/)
  • buildings and maps should not be selectable / clickable
  • - better handle removing buildings when switching maps
  • - (!) do NOT save all the tiles generated by osm3d as children in 3dstreet json, instead ensure that any children of street-geo are not saved; look at example from environment component
  • - better handle copyright notices adding / hiding for OpenStreetMap
  • - test saving / loading

@kfarr kfarr linked an issue Aug 12, 2024 that may be closed by this pull request
@kfarr
Copy link
Collaborator Author

kfarr commented Aug 13, 2024

wip:
image

@kfarr
Copy link
Collaborator Author

kfarr commented Aug 14, 2024

things this doesn't support:

  • this uses the default tile.openstreetmap.org service. The osm4vr component does not yet support proper appending of api key in tile image requests to use other, paid hosted tile services.

Copy link
Collaborator

@vincentfretin vincentfretin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks sane. I have no specific comments on this one.

@kfarr kfarr merged commit 51f0ee2 into main Aug 15, 2024
1 check passed
@kfarr kfarr deleted the osm4vr-actually-testing-out branch August 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add osm map type
2 participants