fix lint errors #530
Merged
fix lint errors #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for 3dstreet-core-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| // load from URL encoded Streetplan JSON | ||
| if (data.streetplanEncJSON) { | ||
| const streetplanJSON = decodeURIComponent(encodedString); | ||
| const streetplanJSON = decodeURIComponent(data.streetplanEncJSON); |
There was a problem hiding this comment.
It seems you fixed a real issue here. Great.
| @@ -1,4 +1,4 @@ | |||
| import React, { useEffect, useRef, useState } from 'react'; | |||
| import { useEffect, useRef, useState } from 'react'; | |||
There was a problem hiding this comment.
You need to use useCallback for handleClickOutside
| @@ -60,7 +60,7 @@ const SceneEditTitle = ({ sceneData }) => { | |||
| <input | |||
| className={styles.title} | |||
| value={title} | |||
| onChange={handleChange} | |||
| // onChange={handleChange} | |||
There was a problem hiding this comment.
Judging by how I understood the code, there is no need to use the onChange handler for this input, at least now. Because the new scene title is entered in the prompt window. Related issue: 3DStreet/3dstreet-editor#311
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #527