Skip to content

Commit

Permalink
Add a camerachanged event you can use with pathtracer, remove debounc…
Browse files Browse the repository at this point in the history
…e for EditorControls change event
  • Loading branch information
vincentfretin committed Aug 31, 2024
1 parent 3cf8194 commit 2118c10
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
13 changes: 4 additions & 9 deletions src/editor/lib/EditorControls.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import debounce from 'lodash-es/debounce';
import { currentOrthoDir } from './cameras';

/**
Expand Down Expand Up @@ -56,10 +55,6 @@ THREE.EditorControls = function (_object, domElement) {

var changeEvent = { type: 'change' };

this.dispatchChange = debounce(() => {
scope.dispatchEvent(changeEvent);
}, 100);

this.focus = function (target) {
if (this.isOrthographic) {
return;
Expand Down Expand Up @@ -165,7 +160,7 @@ THREE.EditorControls = function (_object, domElement) {
object.position.add(delta);
center.add(delta);

scope.dispatchChange();
scope.dispatchEvent(changeEvent);
};

var ratio = 1;
Expand Down Expand Up @@ -201,7 +196,7 @@ THREE.EditorControls = function (_object, domElement) {
object.position.add(delta);
}

scope.dispatchChange();
scope.dispatchEvent(changeEvent);
};

this.rotate = function (delta) {
Expand All @@ -224,7 +219,7 @@ THREE.EditorControls = function (_object, domElement) {

object.lookAt(center);

scope.dispatchChange();
scope.dispatchEvent(changeEvent);
};

// mouse
Expand Down Expand Up @@ -440,7 +435,7 @@ THREE.EditorControls = function (_object, domElement) {
object.updateMatrixWorld();
}

scope.dispatchChange();
scope.dispatchEvent(changeEvent);
};
};

Expand Down
3 changes: 3 additions & 0 deletions src/editor/lib/viewport.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,9 @@ export function Viewport(inspector) {
controls.rotationSpeed = 0.0035;
controls.zoomSpeed = 0.05;
controls.setAspectRatio(sceneEl.canvas.width / sceneEl.canvas.height);
controls.addEventListener('change', () => {
Events.emit('camerachanged');
});

sceneEl.addEventListener('newScene', () => {
controls.resetZoom();
Expand Down

0 comments on commit 2118c10

Please sign in to comment.