Skip to content

Commit

Permalink
processor(ticdc): do not ignore ErrRedoWriterStopped (pingcap#9451)
Browse files Browse the repository at this point in the history
  • Loading branch information
CharlesCheung96 authored and 3AceShowHand committed Aug 29, 2023
1 parent a2aee0c commit 2af966e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion cdc/processor/processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,6 @@ func newProcessor(
var processorIgnorableError = []*errors.Error{
cerror.ErrAdminStopProcessor,
cerror.ErrReactorFinished,
cerror.ErrRedoWriterStopped,
}

// isProcessorIgnorableError returns true if the error means the processor exits
Expand Down
2 changes: 1 addition & 1 deletion cdc/processor/processor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ func TestIgnorableError(t *testing.T) {
{nil, true},
{cerror.ErrAdminStopProcessor.GenWithStackByArgs(), true},
{cerror.ErrReactorFinished.GenWithStackByArgs(), true},
{cerror.ErrRedoWriterStopped.GenWithStackByArgs(), true},
{cerror.ErrRedoWriterStopped.GenWithStackByArgs(), false},
{errors.Trace(context.Canceled), true},
{cerror.ErrProcessorTableNotFound.GenWithStackByArgs(), false},
{errors.New("test error"), false},
Expand Down

0 comments on commit 2af966e

Please sign in to comment.