Skip to content

Conversation

@tcheeric
Copy link
Collaborator

Summary

  • add reposilite distribution management and repository definitions to the root POM
  • propagate reposilite distribution and repository sections to all module POMs

Testing

  • mvn -q verify (fails: CreateInvoiceParamTest, PayBolt11InvoiceInvoiceResponseTest, PayLightningAddressInvoiceResponseTest)

https://chatgpt.com/codex/tasks/task_b_68a64afb04a08331b2bd9fdf8020c3d9

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR configures a custom Reposilite Maven repository for the project by adding distribution management and repository definitions to both the root POM and all module POMs.

  • Adds Reposilite repository configuration for both releases and snapshots
  • Propagates the same repository settings to all Maven modules in the project

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pom.xml Adds root-level Reposilite distribution management and repository configuration
phoenixd-test/pom.xml Duplicates Reposilite configuration in test module
phoenixd-rest/pom.xml Duplicates Reposilite configuration in REST module
phoenixd-model/pom.xml Duplicates Reposilite configuration in model module
phoenixd-base/pom.xml Duplicates Reposilite configuration in base module

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

<id>reposilite-releases</id>
<url>https://maven.398ja.xyz/releases</url>
</repository>
</repositories>
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distributionManagement and repositories sections are duplicated across all module POMs. Since these modules inherit from the root POM, this configuration should be inherited automatically and doesn't need to be redefined in each module.

Suggested change
</repositories>

Copilot uses AI. Check for mistakes.
<id>reposilite-releases</id>
<url>https://maven.398ja.xyz/releases</url>
</repository>
</repositories>
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distributionManagement and repositories sections are duplicated across all module POMs. Since these modules inherit from the root POM, this configuration should be inherited automatically and doesn't need to be redefined in each module.

Suggested change
</repositories>

Copilot uses AI. Check for mistakes.
<id>reposilite-releases</id>
<url>https://maven.398ja.xyz/releases</url>
</repository>
</repositories>
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distributionManagement and repositories sections are duplicated across all module POMs. Since these modules inherit from the root POM, this configuration should be inherited automatically and doesn't need to be redefined in each module.

Suggested change
</repositories>

Copilot uses AI. Check for mistakes.
<id>reposilite-releases</id>
<url>https://maven.398ja.xyz/releases</url>
</repository>
</repositories>
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distributionManagement and repositories sections are duplicated across all module POMs. Since these modules inherit from the root POM, this configuration should be inherited automatically and doesn't need to be redefined in each module.

Suggested change
</repositories>

Copilot uses AI. Check for mistakes.
@tcheeric tcheeric merged commit 78eff6f into develop Aug 20, 2025
1 of 4 checks passed
@tcheeric tcheeric deleted the codex/update-distributionmanagement-in-pom-files branch August 20, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant