-
Notifications
You must be signed in to change notification settings - Fork 1
Refactor/#341 2차 스프린트 3차 QA 반영 #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The head ref may contain hidden characters: "refactor/#341-3\uCC28-qa"
Conversation
dev-domo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
깔꼼합니다
| protocol IsValidQuestAnswerUseCase { | ||
| func execute(previousText: String, changingText: String) -> Bool | ||
| func executeWhenQuestionType(previousText: String, changingText: String) -> Bool | ||
| func executeWhenActiceType(previousText: String, changingText: String, imgCount: Int) -> Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파라미터가 서로 다르니까 두 메서드 다 execute로 해도 나쁘지 않을듯? 개인 취향인 것 같습니당
| import Combine | ||
| import UIKit | ||
|
|
||
| enum ArchiveViewControllerEntryPoint { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다~
| changingText: changingText, | ||
| imgCount: imgCount | ||
| ) | ||
| isValidTextSubject.send(isValidText) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 반영 감사합니당
🔗 연결된 이슈
📄 작업 내용
💻 주요 코드 설명
아카이브 뷰컨트롤러 진입점 구분
수정하기 기능을 추가하면서 수정 완료 후 푸시된 아카이브에서 close를 하면 pop할 때 다시 수정뷰컨트롤러로 돌아가는 문제가 있었습니다. 그래서 아예 루트를 퀘스트메인으로 바꾸는 코드를 썼었는데 이게 이번 QA에서 마이페이지에서 진입 시 퀘스트메인으로 가는 오류가 잡혔더라구요. 그래서 진입점을 구분해서 분기처리를 해줬습니다.
행동형 퀘스트 수정