Merged
Conversation
Pull Request Test Coverage Report for Build 1869879250
💛 - Coveralls |
Instead of allowing it and doing nothing
Also tests validating without --file
I just changed it and it has no coverage... I'll be good and add some :)
Collaborator
Author
|
Moved some code a bit and made running without I've got this other commit to generate a source file that adds all the metadata to pico builds: Daft-Freak@9f9adc5 (requires this for the custom tags/ids Daft-Freak/32blit-beta@9275948) |
Contributor
|
Thank you! The Pico stuff is interesting - I didn't know there was so much capacity for metadata. Parseable by blithub? |
Collaborator
Author
|
Added parsing for the extra fields to the metadata bot, so probably. (Though I did have to write a parser instead of just running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves parsing the images up a bit and rejects images that are the wrong size (making the error messages more accurate).
This still has the problem that only 32blit and SDL macOS builds run the tool, so other builds don't validate anything. (Resulting in there being a couple of PicoSystem projects that don't build for 32blit due to some values being too long...)