Skip to content

Comments

Validate metadata image sizes#94

Merged
Gadgetoid merged 5 commits into32blit:masterfrom
Daft-Freak:patch-1
Mar 10, 2022
Merged

Validate metadata image sizes#94
Gadgetoid merged 5 commits into32blit:masterfrom
Daft-Freak:patch-1

Conversation

@Daft-Freak
Copy link
Collaborator

Moves parsing the images up a bit and rejects images that are the wrong size (making the error messages more accurate).

This still has the problem that only 32blit and SDL macOS builds run the tool, so other builds don't validate anything. (Resulting in there being a couple of PicoSystem projects that don't build for 32blit due to some values being too long...)

@coveralls
Copy link

coveralls commented Feb 17, 2022

Pull Request Test Coverage Report for Build 1869879250

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.4%) to 79.462%

Files with Coverage Reduction New Missed Lines %
ttblit/tool/metadata.py 22 76.92%
Totals Coverage Status
Change from base Build 1756581373: 1.4%
Covered Lines: 1153
Relevant Lines: 1451

💛 - Coveralls

Instead of allowing it and doing nothing
Also tests validating without --file
I just changed it and it has no coverage... I'll be good and add some :)
@Daft-Freak
Copy link
Collaborator Author

Moved some code a bit and made running without --file exit after validation instead of reading the file and doing nothing. Also tests.

I've got this other commit to generate a source file that adds all the metadata to pico builds: Daft-Freak@9f9adc5 (requires this for the custom tags/ids Daft-Freak/32blit-beta@9275948)

@Gadgetoid
Copy link
Contributor

Thank you!

The Pico stuff is interesting - I didn't know there was so much capacity for metadata. Parseable by blithub?

@Gadgetoid Gadgetoid merged commit 7ec4b88 into 32blit:master Mar 10, 2022
@Daft-Freak Daft-Freak deleted the patch-1 branch March 10, 2022 17:10
@Daft-Freak
Copy link
Collaborator Author

Added parsing for the extra fields to the metadata bot, so probably. (Though I did have to write a parser instead of just running picotool and grabbing its output...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants