Fix RLE decompress with bitstring >= 4.1.0#103
Merged
Gadgetoid merged 2 commits into32blit:masterfrom Jun 17, 2024
Merged
Conversation
Pull Request Test Coverage Report for Build 9112910058Details
💛 - Coveralls |
Collaborator
Author
|
So, I just checked and this suggests that any new installs since last August are broken... |
Contributor
|
Woof. I guess it would be a good idea to expedite a new tools release! |
Contributor
|
Oh gosh as a maintainer is it now my duty to check that |
Collaborator
Author
|
Should be the same as the png but raw paletted, unless I messed up and made accidental malware. 🤷 Yeah, releasing this would be good, think I just missed hitting this the last time I reinstalled. (Not sure if that was lucky or not 🤔 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant part from bitstring release notes:
This was breaking image encoding as well as it seems a decompress happens at some point.
Also change the test to use some real data. (It wasn't failing as the data was all the same, so all enceded as runs)