Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reduce memory retained by incoming transaction queues and avoid unnecessary serialization allocations in
TransactionsMsgHandler.retentries before admission. Both smart-contract events and ordinary transaction tasks retain the cleaned transaction.TransactionCapsule, avoiding the full transaction byte arrays created by temporaryTransactionMessageobjects during request checks and cleanup.Why are these changes required?
Queued transactions could retain removable padding or oversized payloads until worker processing and downstream validation. During a backlog, these bytes accumulate in protobuf objects and, for smart-contract messages, cached serialized data. Cleaning and checking transactions before admission reduces this retained memory, while avoiding temporary message construction reduces allocation pressure.
The cleanup preserves signed
raw_dataand transaction IDs. The size check is an early admission guard; full transaction validation still runs downstream.This PR has been tested by:
checkstyleMain,checkstyleTest, andgit diff --checkpassed.