Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign keys delete and update actions #197

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Conversation

Soleyu
Copy link
Contributor

@Soleyu Soleyu commented Dec 29, 2024

Added logic to create table so that it can parse on delete and on update clauses. Now you can just add on_delete and on_cascade directly as arguments instead of making a query to enable for example on delete cascade.

I added this mainly because I was annoyed to having to do a query and it seemed like a small change to do.

@Soleyu
Copy link
Contributor Author

Soleyu commented Dec 29, 2024

Also, I seem to have polluted it with a commit I did to change something, Im sorry about that Im a bit new with this, on that note, if I did this whole pull request wrong and should have done soemthing else in order to submit stuff then I apologize.

Copy link
Owner

@2shady4u 2shady4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Soleyu
Thank you for working on this 😃

I would like to request some small changes to the if-statements 😄

Also, the formatting check job (Static Checks / Format (clang-format)) fails atm so that it something you'll need to fix.

@2shady4u 2shady4u added the enhancement New feature or request label Dec 30, 2024
@Soleyu
Copy link
Contributor Author

Soleyu commented Dec 30, 2024

The last commit should resolve any issues I think. Also thanks for having patiencve with me!

@2shady4u
Copy link
Owner

Hello @Soleyu,

Everything seems to be good with the code now 😄
Would it be possible to squash your commits into one?
(See the Git checlist here: https://docs.godotengine.org/en/latest/contributing/workflow/pr_review_guidelines.html#git-checklist)

@Soleyu
Copy link
Contributor Author

Soleyu commented Dec 31, 2024

Hello @Soleyu,

Everything seems to be good with the code now 😄 Would it be possible to squash your commits into one? (See the Git checlist here: https://docs.godotengine.org/en/latest/contributing/workflow/pr_review_guidelines.html#git-checklist)

Sure thing! Ill take me a bit as I need to figure out how exactly to do that, but it should be done today.

Added logic to create table so that it can parse on delete and on update clauses. Now you can just add on_delete and on_cascade directly as arguments instead of making a query to enable on delete cascade for example.
@Soleyu
Copy link
Contributor Author

Soleyu commented Dec 31, 2024

Hey @2shady4u

Well squashing commits was easier than I expected. Its done now, anything that I should do?

@2shady4u 2shady4u merged commit 8aa5bb4 into 2shady4u:master Dec 31, 2024
1 check passed
@2shady4u
Copy link
Owner

@Soleyu

It has been merged 😄
Thank you for your contribution!

@2shady4u 2shady4u added this to the v4.5 milestone Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants