-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foreign keys delete and update actions #197
Conversation
Also, I seem to have polluted it with a commit I did to change something, Im sorry about that Im a bit new with this, on that note, if I did this whole pull request wrong and should have done soemthing else in order to submit stuff then I apologize. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Soleyu
Thank you for working on this 😃
I would like to request some small changes to the if-statements 😄
Also, the formatting check job (Static Checks / Format (clang-format)) fails atm so that it something you'll need to fix.
The last commit should resolve any issues I think. Also thanks for having patiencve with me! |
Hello @Soleyu, Everything seems to be good with the code now 😄 |
Sure thing! Ill take me a bit as I need to figure out how exactly to do that, but it should be done today. |
Added logic to create table so that it can parse on delete and on update clauses. Now you can just add on_delete and on_cascade directly as arguments instead of making a query to enable on delete cascade for example.
Hey @2shady4u Well squashing commits was easier than I expected. Its done now, anything that I should do? |
It has been merged 😄 |
Added logic to create table so that it can parse on delete and on update clauses. Now you can just add on_delete and on_cascade directly as arguments instead of making a query to enable for example on delete cascade.
I added this mainly because I was annoyed to having to do a query and it seemed like a small change to do.