WIP: add the linestyles option for implicants drawing #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dettorer
force-pushed
the
implicant-linestyles
branch
from
9412a84 to
48679f8
Compare
Owner
|
How would you like to be attributed? Would this be okay? |
Contributor
Author
|
That's really nice of you to ask, I'd like Paul Hervot please. |
Owner
|
Great thanks! I've skimmed through the PR and it looks good in general. See my comment in the original issue for now. I'm really happy that you added test cases! 🌟 Thank you! |
Dettorer
changed the title
2pi
added a commit
to Dettorer/karnaugh-map
that referenced
this pull request
Dec 15, 2021
For pull request 2pi#17
Owner
|
I've added attribution as discussed above. Regarding licensing. Similarly to #7 (comment) I just want to check that you are aware and okay with the licensing(CC BY-SA). |
Dettorer
force-pushed
the
implicant-linestyles
branch
from
95203c7 to
437c587
Compare
Contributor
Author
|
I forgot to answer your last question too, sorry. I'm totally ok with the current licensing. |
The map was technically incorrect, remove the terms to just showcase the implicants and the linestyles.
Contributor
Author
|
Thanks for the proofread and extra test! Do you want me to do anything else with this PR? |
Owner
|
Perfect! No I don't think so. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16