Add tested features (Kronecker, isotropic) and their tests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenardrommel
commented
Sep 18, 2025
- Updated .gitignore to exclude additional local files. - Introduced 'kron' function in _arithmetic.py for Kronecker product operations. - Added 'as_dense' utility function in utils.py to convert linear operators to dense matrices. - Implemented new test cases for isotropic additive linear operators and their properties. - Enhanced existing tests for matrix operations and added cases for Kronecker products.
- Introduced a new test file `test_eigen.py` to validate EigenD and related operations. - Enhanced existing tests in `test_isotropicadd.py` to include transformations of linear operators. - Added a new test `test_kronecker_lsqrt_preserves_matmul` in `test_kronecker.py` to verify the behavior of the square root of Kronecker products. - Expanded `test_utils.py` with various cases for block matrices, low-rank operators, isotropic scaling, and more. - Ensured all tests check for shape and dense representation consistency across linear operators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enhanced and tested the kronecker linear operator as well as some other minor changes.