fix: Add default values to Dockerfile arguments

2b-t · Feb 4, 2024 · 9e90902 · 9e90902
1 parent 3a4f9ed
commit 9e90902
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/templates/ros/docker/Dockerfile b/templates/ros/docker/Dockerfile
@@ -3,7 +3,7 @@
 ##############
 FROM ros:noetic-robot as base
 
-ARG CATKIN_WORKSPACE_DIR=${CATKIN_WORKSPACE_DIR}
+ARG CATKIN_WORKSPACE_DIR="/catkin_ws"
 
 LABEL org.opencontainers.image.authors="tobit.flatscher@outlook.com"
 LABEL description="ROS Noetic Docker template"
@@ -31,9 +31,9 @@ ENV DEBIAN_FRONTEND=dialog
 #####################
 FROM base as dev
 
-ARG USERNAME=${USERNAME}
-ARG UID=${UID}
-ARG GID=${GID}
+ARG USERNAME="developer"
+ARG UID=1000
+ARG GID=1000
 
 ENV DEBIAN_FRONTEND=noninteractive
 

diff --git a/templates/ros2/docker/Dockerfile b/templates/ros2/docker/Dockerfile
@@ -3,7 +3,7 @@
 ##############
 FROM ros:humble-ros-base as base
 
-ARG AMENT_WORKSPACE_DIR=${AMENT_WORKSPACE_DIR}
+ARG AMENT_WORKSPACE_DIR="/ament_ws"
 
 LABEL org.opencontainers.image.authors="tobit.flatscher@outlook.com"
 LABEL description="ROS 2 Humble Docker template"
@@ -36,9 +36,9 @@ ENV DEBIAN_FRONTEND=dialog
 #####################
 FROM base as dev
 
-ARG USERNAME=${USERNAME}
-ARG UID=${UID}
-ARG GID=${GID}
+ARG USERNAME="developer"
+ARG UID=1000
+ARG GID=1000
 
 ENV DEBIAN_FRONTEND=noninteractive