Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#4 assignment 2 #6

Merged
merged 6 commits into from
Oct 24, 2021
Merged

Feature/#4 assignment 2 #6

merged 6 commits into from
Oct 24, 2021

Conversation

yangsubinn
Copy link
Member

πŸ“Œ κ΄€λ ¨ 이슈

closed #4

πŸ“Œ λ³€κ²½ 사항 및 이유

μ§€λ‚œ 과제 λ•Œ μŠ€ν† λ¦¬λ³΄λ“œμ—μ„œ μž‘μ•˜λ˜ μ˜€ν† λ ˆμ΄μ•„μ›ƒμ„ μ œκ±°ν•˜κ³  snapkit 라이브러리λ₯Ό μ‚¬μš©ν•΄μ„œ λ ˆμ΄μ•„μ›ƒμ„ μž‘μ•˜κ³ ,
μ½”λ“œλ‘œ νƒ­λ°”λ₯Ό κ΅¬ν˜„ν•΄μ„œ μ—°κ²°ν•΄μ€¬μŠ΅λ‹ˆλ‹€.

πŸ“Œ PR Point

λ­”κ°€ 더 효율적으둜 지 수 μžˆμ„ 것 κ°™λ‹€λ˜μ§€... λ§˜μ— μ•ˆλ“ λ‹€λ˜μ§€.. ν•˜λŠ” 뢀뢄이 있으면 λ‹€ λ§μ”€ν•΄μ£Όμ„Έμš” 쇽μƒ₯ μ—΄μ‹¬νžˆ κ³΅λΆ€ν•΄μ™€μ„œ λ°˜μ˜ν•˜κ² μŠ΅λ‹ˆλ‹€
마크λ₯Ό μ¨μ„œ μ½”λ“œλ“€μ„ μ’€ 더 보기 μ‰½κ²Œ ν•˜λ €κ³  ν–ˆλŠ”λ° 잘.. λ³΄μ΄μ‹€κΉŒμš”....

πŸ“Œ μ°Έκ³  사항

λΌμ΄λΈŒλŸ¬λ¦¬λž‘ 에셋 μΆ”κ°€ν•œ 것 λ•Œλ¬Έμ— 파일이 ꡉμž₯히 λ§Žμ€ 것 같은데,,, μŠ‰μŠ‰ λ„˜κ²¨μ„œ μ½”λ“œλΆ€λΆ„λ§Œ 잘 λ΄μ£Όμ‹œλ©΄ κ°μ‚¬ν•˜κ² μŠ΅λ‹ˆλ‹Ή...
λ‹€μŒμ£Ό μ‹œν—˜μ΄λΌ ν•  μ‹œκ°„μ΄ 없을 것 κ°™μ•„μ„œ 일찍 ν–ˆλŠ”λ°,, 천천히 μ§„μ§œ 천천히..! λ³΄μ‹œκ³  μ½”λ“œλ¦¬λ·° ν•΄μ£Όμ„Έμš”..!
μ‹œν—˜ λΏŒμ‹œκ³  리뷰 λ°˜μ˜ν•˜λŸ¬ μ˜€κ² μŠ΄λ‹ˆλ‹€β˜„οΈ


class AddVC: UIViewController {

// MARK: - Life Cycle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

였였... 저도 MARK μž‘μ„±ν•΄μ•Όκ² μ–΄μš”.... 더 깔끔해 보이고 쒋은거 κ°™μ• μš€...!

Comment on lines 44 to 92
func setupLayout() {
logoImageView.snp.makeConstraints { make in
make.top.equalToSuperview().offset(100)
make.centerX.equalToSuperview()
make.width.equalTo(117)
make.height.equalTo(40)
}

titleLabel.snp.makeConstraints { make in
make.top.equalTo(logoImageView.snp.bottom).offset(14)
make.centerX.equalToSuperview()
}

subLabel.snp.makeConstraints { make in
make.top.equalTo(titleLabel.snp.bottom).offset(14)
make.centerX.equalToSuperview()
}

nameTextField.snp.makeConstraints { make in
make.top.equalTo(subLabel.snp.bottom).offset(68)
make.leading.trailing.equalToSuperview().inset(22)
make.height.equalTo(50)
}

emailTextField.snp.makeConstraints { make in
make.top.equalTo(nameTextField.snp.bottom).offset(17)
make.leading.trailing.equalToSuperview().inset(22)
make.height.equalTo(50)
}

pwTextField.snp.makeConstraints { make in
make.top.equalTo(emailTextField.snp.bottom).offset(17)
make.leading.trailing.equalToSuperview().inset(22)
make.height.equalTo(50)
}

signUpButton.snp.makeConstraints { make in
make.top.equalTo(pwTextField.snp.bottom).offset(73)
make.leading.equalToSuperview().inset(22)
}

nextButton.snp.makeConstraints { make in
make.centerY.equalTo(signUpButton.snp.centerY)
make.trailing.equalToSuperview().inset(22)
make.width.equalTo(74)
make.height.equalTo(50)
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μŠ€λƒ…ν‚·μ΄ μ΄λ ‡κ²Œ μ‚¬μš©ν•˜λŠ” κ±°κ΅°μš”..! 과제 λ¦¬νŒ©ν† λ§ν• λ•Œ ν•œλ²ˆ μ‚¬μš©ν•΄λ³΄κ² μŠ΅λ‹ˆλ‹€...!

Copy link

@hwangJi-dev hwangJi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜λΉˆλ‹˜.. snapkit 정말 μž˜μ“°μ‹œλ„€μš”! 그리고 MARK둜 κ΅¬λΆ„ν•΄μ£Όμ…”μ„œ λ„ˆλ¬΄ νŽΈν•˜κ²Œ μ½μ—ˆμŠ΅λ‹ˆλ‹€!!!! 졜고짱짱.. 저도 많이 λ°°μ›Œκ°‘λ‹ˆλ‹€~~πŸ‘πŸ»

let lockerVC = self.storyboard?.instantiateViewController(withIdentifier: "LockerVC")
else {return}

/// νƒ­λ°” μ•„μ΄ν…œλ³„ 이름

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

였!! μ €λŠ” VCλ³„λ‘œ λ¬Άμ–΄μ„œ 속성을 μ§€μ •ν•΄μ€¬μ—ˆλŠ”λ°, 같은 속성끼리 μ½”λ“œλ₯Ό λ¬ΆμœΌλ‹ˆκΉŒ 더 κ°€λ…μ„±μžˆκ³  μ’‹λ„€μš”!!!! μ§±μž…λ‹ˆλ‹€πŸ‘πŸ»

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ·ΈλŸ¬λ„€μš”!! VCλ³„λ‘œ λ¬Άμ–΄μ„œ μ§€μ •ν•΄μ£Όλ‹ˆ 훨씬 보기 νŽΈν•œ 것 κ°™μ•„μš”!! 저도 참고해보도둝 ν•˜κ² μŠ΅λ‹ˆλ‹€!! :)


nameTextField.snp.makeConstraints { make in
make.top.equalTo(subLabel.snp.bottom).offset(68)
make.leading.trailing.equalToSuperview().inset(22)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 μŠ€λƒ…ν‚· μ“Έ λ•Œ leading, trailing λ”°λ‘œ μ½”λ“œ μ¨μ€¬μ—ˆλŠ”λ° μ΄λ ‡κ²Œ κ°™μ΄μ“°λŠ” 방법이 μžˆκ΅°μš”!! λŒ€λ°• μ€μ€ν•΄κ°‘λ‹ˆλ‹€~~~πŸ’œ

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 λ°”λ‘œ μŠ€λƒ…ν‚·μ΄κ΅°μš”!! leading, trailing 같이 μ“°λŠ” 방법 μ€μ€ν•΄κ°‘λ‹ˆλ‹€~!! 22γ…Žγ…Ž

logoImageView.image = UIImage(named: "Google")
}

func setupLayout() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ½”λ“œ λ‚΄μ—μ„œ

//MARK:- Layout
extension SignUpViewController {
   func setupLayout() { 
   // 블라블라~~
  }
}

이런 μ‹μœΌλ‘œ Layoutꡬ성뢀λ₯Ό extension으둜 λ°‘μœΌλ‘œ λΉΌμ€˜λ„ 가독성 μΈ‘λ©΄μ—μ„œ 쒋을 것 κ°™μ•„μš”~~ πŸ€—

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„ μ•„μ˜ˆ λ ˆμ΄μ•„μ›ƒμž‘λŠ” ν•¨μˆ˜λ₯Ό extension에도 λΊ„ 수 μžˆκ΅°μ—¬..! 쇽μƒ₯ λ°˜μ˜ν•΄λ³΄κ² μŠ΅λ‹ˆλ‹€πŸ‘

self.dismiss(animated: true, completion: nil)
/// Main이 μ•„λ‹Œ λ”°λ‘œ μƒμ„±ν•œ YouTubeMainμ΄λΌλŠ” μŠ€ν† λ¦¬λ³΄λ“œλ₯Ό μ„ μ–Έ
let youtubeMainStoryboard = UIStoryboard.init(name: "YoutubeMain", bundle: nil)
guard let nextVC = youtubeMainStoryboard.instantiateViewController(withIdentifier: "CustomTabBarController") as? CustomTabBarController else {return}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TabBarControllerλ₯Ό μ€„μ—¬μ„œ TBC 라고 μ§€μ–΄μ€˜λ„ 쒋을 것 κ°™μ•„μš”! γ…Žγ…Ž

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

였 TBC...! 저도 λ°”κΏ”μ•Όκ² μ–΄μš€... TBC...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ™€μ˜€ μ’‹μ•„μš”.. TabBarController λ„ˆλ¬΄ κΈΈλ”λΌκ΅¬μš”... 쇽μƒ₯ κ°‘λ‹ˆλ‹€!

Copy link

@noah0316 noah0316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마크 μ‚¬μš©ν•΄μ£Όμ‹ λ•μ— μ–΄λ–€ 역할을 ν•˜λŠ” μΉœκ΅¬λ“€μΈμ§€ 더 잘 λ³Ό 수 μžˆμ–΄ μ’‹μ•˜μŠ΅λ‹ˆλ‹€~!!γ…Žγ…Ž
같은 결을 가진 μΉœκ΅¬λ“€μ„ λ¬Άμ–΄μ„œ μž‘μ„±ν•΄μ£Όμ‹  뢀뢄듀이 μΈμƒκΉŠμ—ˆμŠ΅λ‹ˆλ‹€ μ„ λ°°!!😁

let lockerVC = self.storyboard?.instantiateViewController(withIdentifier: "LockerVC")
else {return}

/// νƒ­λ°” μ•„μ΄ν…œλ³„ 이름

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ·ΈλŸ¬λ„€μš”!! VCλ³„λ‘œ λ¬Άμ–΄μ„œ μ§€μ •ν•΄μ£Όλ‹ˆ 훨씬 보기 νŽΈν•œ 것 κ°™μ•„μš”!! 저도 참고해보도둝 ν•˜κ² μŠ΅λ‹ˆλ‹€!! :)


nameTextField.snp.makeConstraints { make in
make.top.equalTo(subLabel.snp.bottom).offset(68)
make.leading.trailing.equalToSuperview().inset(22)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 λ°”λ‘œ μŠ€λƒ…ν‚·μ΄κ΅°μš”!! leading, trailing 같이 μ“°λŠ” 방법 μ€μ€ν•΄κ°‘λ‹ˆλ‹€~!! 22γ…Žγ…Ž

@yangsubinn yangsubinn merged commit 2ace1cb into main Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] iOS 2차 과제
4 participants