week3-assignment #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoonAh-dev
approved these changes
Dec 24, 2021
Comment on lines
+22
to
+24
| func setLayout(){ | ||
| collectionImageView.layer.cornerRadius = CGFloat(25) | ||
| } |
There was a problem hiding this comment.
ν¨μ λ΄λΆμμ νλ μΌμ΄ UIComponentμ cornerκ°μ μ£Όλκ±°λΌμ, Layout보λ€λ configUIκ° λ§μ κ±° κ°μμ!
Comment on lines
+10
to
+34
| struct HomeContentData { | ||
|
|
||
| let title: String | ||
| let information: String | ||
| let authorImageName: String | ||
| let thumbImageName: String | ||
|
|
||
| func makeThumbImage() -> UIImage? { | ||
| return UIImage(named: thumbImageName) | ||
| } | ||
|
|
||
| func makeAuthorImage() -> UIImage? { | ||
| return UIImage(named: authorImageName) | ||
| } | ||
| } | ||
|
|
||
| struct HomeTopData { | ||
| let name : String | ||
|
|
||
| let iconImageName: String | ||
|
|
||
| func makeIconImage() -> UIImage? { | ||
| return UIImage(named: iconImageName) | ||
| } | ||
| } |
There was a problem hiding this comment.
κΉλνκ² μ μΌμ΄μπ
Comment on lines
+31
to
+36
| homeTableView.dataSource = self | ||
| homeTableView.delegate = self | ||
| homeCollectionView.dataSource = self | ||
| homeCollectionView.delegate = self | ||
| tagCollectionView.dataSource = self | ||
| tagCollectionView.delegate = self |
There was a problem hiding this comment.
ν¨μλ‘ λ¬Άμ΄μ€λ μ’μ κ² κ°λ€μ!
There was a problem hiding this comment.
μ΄λΆλΆ λ°°μ΄λ‘ λ¬Άκ³ forEachλ‘ μ§μ ν΄μ€λ μ’μλ― μΆμ΅λλ€.
| @IBOutlet weak var tagLabel: UILabel! | ||
|
|
||
| override func awakeFromNib() { | ||
| setLayout() |
There was a problem hiding this comment.
μ΄ λΆλΆμ super.awakeFromNib() μ΄νμ ν΄λ μλ¨Ήλμ?
Comment on lines
+22
to
+27
| func setLayout() { | ||
| tagLayout.layer.cornerRadius = 17 | ||
| tagLayout.layer.borderWidth = 1 | ||
| tagLayout.layer.borderColor = UIColor(red: 212, green: 212, blue: 212, alpha: 1).cgColor | ||
| tagLayout.layer.backgroundColor = UIColor(red: 242, green: 242, blue: 242, alpha: 1).cgColor | ||
| } |
There was a problem hiding this comment.
μ΄ ν¨μλ μ£Όλ‘ νλ μΌμ΄ UI Configurationλ₯Ό μ‘λ μΌμ΄λΌμ ConfigUIκ° μ¬λ°λ₯Έ λ€μ΄λ°μΌ κ² κ°μμ!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π κ΄λ ¨ μ΄μ
#5
π λ³κ²½ μ¬ν λ° μ΄μ
HomeVC μ νλ©΄μ ꡬννμ΅λλ€.
TableVIew, CollectionViewλ₯Ό ꡬννλ©° μ°μ΅ν μ μμμ΅λλ€!
π PR Point
μμΈμ§ TagCollectionViewCell.xib μμ setLayout() ν¨μκ° λμμνλλ°
λΉλνλ©΄ νλ©΄μ μ μ©μ΄ μλμ΄μμ΅λλ€.. 8γ 8
π μ°Έκ³ μ¬ν
HomeVCμ μ°¨λ‘λλ‘
μ λλ€!