Skip to content

Commit

Permalink
GTTF: remove FAILS_ prefix, part 1
Browse files Browse the repository at this point in the history
  • Loading branch information
phajdan.jr@chromium.org committed Nov 1, 2012
1 parent a6a7ced commit e00ccc9
Show file tree
Hide file tree
Showing 33 changed files with 45 additions and 60 deletions.
2 changes: 1 addition & 1 deletion PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
_BANNED_CPP_FUNCTIONS = (
# Make sure that gtest's FRIEND_TEST() macro is not used; the
# FRIEND_TEST_ALL_PREFIXES() macro from base/gtest_prod_util.h should be
# used instead since that allows for FLAKY_, FAILS_ and DISABLED_ prefixes.
# used instead since that allows for FLAKY_ and DISABLED_ prefixes.
(
'FRIEND_TEST(',
(
Expand Down
2 changes: 1 addition & 1 deletion ash/shell_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ TEST_F(ShellTest, IsScreenLocked) {

// Fails on Mac, see http://crbug.com/115662
#if defined(OS_MACOSX)
#define MAYBE_ManagedWindowModeBasics FAILS_ManagedWindowModeBasics
#define MAYBE_ManagedWindowModeBasics DISABLED_ManagedWindowModeBasics
#else
#define MAYBE_ManagedWindowModeBasics ManagedWindowModeBasics
#endif
Expand Down
2 changes: 1 addition & 1 deletion ash/wm/base_layout_manager_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ TEST_F(BaseLayoutManagerTest, FullscreenRootWindowResize) {
// Fails on Mac only. Need to be implemented. http://crbug.com/111279.
#if defined(OS_MACOSX)
#define MAYBE_RootWindowResizeShrinksWindows \
FAILS_RootWindowResizeShrinksWindows
DISABLED_RootWindowResizeShrinksWindows
#else
#define MAYBE_RootWindowResizeShrinksWindows RootWindowResizeShrinksWindows
#endif
Expand Down
2 changes: 1 addition & 1 deletion ash/wm/shelf_layout_manager_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ class ShelfLayoutManagerTest : public ash::test::AshTestBase {

// Fails on Mac only. Need to be implemented. http://crbug.com/111279.
#if defined(OS_MACOSX)
#define MAYBE_SetVisible FAILS_SetVisible
#define MAYBE_SetVisible DISABLED_SetVisible
#else
#define MAYBE_SetVisible SetVisible
#endif
Expand Down
2 changes: 1 addition & 1 deletion ash/wm/toplevel_window_event_handler_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ TEST_F(ToplevelWindowEventHandlerTest, GestureDrag) {

// Verifies pressing escape resets the bounds to the original bounds.
#if defined(OS_MACOSX)
#define MAYBE_EscapeReverts FAILS_EscapeReverts
#define MAYBE_EscapeReverts DISABLED_EscapeReverts
#else
#define MAYBE_EscapeReverts EscapeReverts
#endif
Expand Down
2 changes: 1 addition & 1 deletion ash/wm/window_manager_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ TEST_F(WindowManagerTest, MouseEventCursors) {
}

#if defined(OS_MACOSX)
#define MAYBE_TransformActivate FAILS_TransformActivate
#define MAYBE_TransformActivate DISABLED_TransformActivate
#else
#define MAYBE_TransformActivate TransformActivate
#endif
Expand Down
2 changes: 1 addition & 1 deletion base/debug/stack_trace_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace debug {
// See comments in the #ifdef soup if you intend to change this.
#if defined(OS_WIN)
// Always fails on Windows: crbug.com/32070
#define MAYBE_OutputToStream FAILS_OutputToStream
#define MAYBE_OutputToStream DISABLED_OutputToStream
#else
#define MAYBE_OutputToStream OutputToStream
#endif
Expand Down
6 changes: 2 additions & 4 deletions base/gtest_prod_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
#define FRIEND_TEST_ALL_PREFIXES(test_case_name, test_name) \
FRIEND_TEST(test_case_name, test_name); \
FRIEND_TEST(test_case_name, DISABLED_##test_name); \
FRIEND_TEST(test_case_name, FLAKY_##test_name); \
FRIEND_TEST(test_case_name, FAILS_##test_name)
FRIEND_TEST(test_case_name, FLAKY_##test_name)

// C++ compilers will refuse to compile the following code:
//
Expand Down Expand Up @@ -62,7 +61,6 @@
#define FORWARD_DECLARE_TEST(test_case_name, test_name) \
class test_case_name##_##test_name##_Test; \
class test_case_name##_##DISABLED_##test_name##_Test; \
class test_case_name##_##FLAKY_##test_name##_Test; \
class test_case_name##_##FAILS_##test_name##_Test
class test_case_name##_##FLAKY_##test_name##_Test

#endif // BASE_GTEST_PROD_UTIL_H_
3 changes: 1 addition & 2 deletions base/json/json_parser.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ friend class test_case_name##_##test_name##_Test
#define FRIEND_TEST_ALL_PREFIXES(test_case_name, test_name) \
FRIEND_TEST(test_case_name, test_name); \
FRIEND_TEST(test_case_name, DISABLED_##test_name); \
FRIEND_TEST(test_case_name, FLAKY_##test_name); \
FRIEND_TEST(test_case_name, FAILS_##test_name)
FRIEND_TEST(test_case_name, FLAKY_##test_name)
#endif // OS_CHROMEOS

namespace base {
Expand Down
4 changes: 2 additions & 2 deletions base/message_loop_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1643,7 +1643,7 @@ TEST(MessageLoopTest, PostDelayedTask_SharedTimer_SubPump) {
// TODO(darin): MessageLoop does not support deleting all tasks in the
// destructor.
// Fails, http://crbug.com/50272.
TEST(MessageLoopTest, FAILS_EnsureDeletion) {
TEST(MessageLoopTest, DISABLED_EnsureDeletion) {
RunTest_EnsureDeletion(MessageLoop::TYPE_DEFAULT);
RunTest_EnsureDeletion(MessageLoop::TYPE_UI);
RunTest_EnsureDeletion(MessageLoop::TYPE_IO);
Expand All @@ -1652,7 +1652,7 @@ TEST(MessageLoopTest, FAILS_EnsureDeletion) {
// TODO(darin): MessageLoop does not support deleting all tasks in the
// destructor.
// Fails, http://crbug.com/50272.
TEST(MessageLoopTest, FAILS_EnsureDeletion_Chain) {
TEST(MessageLoopTest, DISABLED_EnsureDeletion_Chain) {
RunTest_EnsureDeletion_Chain(MessageLoop::TYPE_DEFAULT);
RunTest_EnsureDeletion_Chain(MessageLoop::TYPE_UI);
RunTest_EnsureDeletion_Chain(MessageLoop::TYPE_IO);
Expand Down
14 changes: 1 addition & 13 deletions base/test/test_suite.cc
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,6 @@ bool TestSuite::IsMarkedFlaky(const testing::TestInfo& test) {
return strncmp(test.name(), "FLAKY_", 6) == 0;
}

// static
bool TestSuite::IsMarkedFailing(const testing::TestInfo& test) {
return strncmp(test.name(), "FAILS_", 6) == 0;
}

// static
bool TestSuite::IsMarkedMaybe(const testing::TestInfo& test) {
return strncmp(test.name(), "MAYBE_", 6) == 0;
Expand All @@ -141,7 +136,7 @@ bool TestSuite::IsMarkedMaybe(const testing::TestInfo& test) {
bool TestSuite::ShouldIgnoreFailure(const testing::TestInfo& test) {
if (CommandLine::ForCurrentProcess()->HasSwitch(kStrictFailureHandling))
return false;
return IsMarkedFlaky(test) || IsMarkedFailing(test);
return IsMarkedFlaky(test);
}

// static
Expand Down Expand Up @@ -209,13 +204,6 @@ int TestSuite::Run() {
flaky_count == 1 ? "TEST" : "TESTS");
}

// Display the number of tests with ignored failures (FAILS).
int failing_count = GetTestCount(&TestSuite::IsMarkedFailing);
if (failing_count) {
printf(" YOU HAVE %d %s with ignored failures (FAILS prefix)\n\n",
failing_count, failing_count == 1 ? "test" : "tests");
}

#if defined(OS_MACOSX)
// This MUST happen before Shutdown() since Shutdown() tears down
// objects (such as NotificationService::current()) that Cocoa
Expand Down
6 changes: 3 additions & 3 deletions chrome/browser/browser_keyevents_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ class BrowserKeyEventsTest : public InProcessBrowserTest {
#define MAYBE_NormalKeyEvents DISABLED_NormalKeyEvents
#elif defined(OS_LINUX)
// http://crbug.com/129235
#define MAYBE_NormalKeyEvents FAILS_NormalKeyEvents
#define MAYBE_NormalKeyEvents DISABLED_NormalKeyEvents
#else
#define MAYBE_NormalKeyEvents NormalKeyEvents
#endif
Expand Down Expand Up @@ -399,7 +399,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, MAYBE_NormalKeyEvents) {

#if defined(OS_LINUX)
// http://crbug.com/129235
#define MAYBE_CtrlKeyEvents FAILS_CtrlKeyEvents
#define MAYBE_CtrlKeyEvents DISABLED_CtrlKeyEvents
#else
#define MAYBE_CtrlKeyEvents CtrlKeyEvents
#endif
Expand Down Expand Up @@ -529,7 +529,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, DISABLED_CommandKeyEvents) {
#define MAYBE_AccessKeys DISABLED_AccessKeys
#elif defined(OS_LINUX)
// http://crbug.com/129235
#define MAYBE_AccessKeys FAILS_AccessKeys
#define MAYBE_AccessKeys DISABLED_AccessKeys
#else
#define MAYBE_AccessKeys AccessKeys
#endif
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ TEST_F(ProtocolHandlerRegistryTest, TestOSRegistration) {
#if defined(OS_LINUX)
// TODO(benwells): When Linux support is more reliable and
// http://crbut.com/88255 is fixed this test will pass.
#define MAYBE_TestOSRegistrationFailure FAILS_TestOSRegistrationFailure
#define MAYBE_TestOSRegistrationFailure DISABLED_TestOSRegistrationFailure
#else
#define MAYBE_TestOSRegistrationFailure TestOSRegistrationFailure
#endif
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/extensions/extension_service_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2703,7 +2703,7 @@ TEST_F(ExtensionServiceTest, DISABLED_DISABLED_UpdatePendingTheme) {

#if defined(OS_CHROMEOS)
// Always fails on ChromeOS: http://crbug.com/79737
#define MAYBE_UpdatePendingExternalCrx FAILS_UpdatePendingExternalCrx
#define MAYBE_UpdatePendingExternalCrx DISABLED_UpdatePendingExternalCrx
#else
#define MAYBE_UpdatePendingExternalCrx UpdatePendingExternalCrx
#endif
Expand Down
4 changes: 2 additions & 2 deletions chrome/browser/extensions/window_open_apitest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ class WindowOpenPanelTest : public ExtensionApiTest {
#if defined(USE_ASH)
// On Ash, this currently fails because we're currently opening new panel
// windows as popup windows instead.
#define MAYBE_WindowOpenPanel FAILS_WindowOpenPanel
#define MAYBE_WindowOpenPanel DISABLED_WindowOpenPanel
#else
#define MAYBE_WindowOpenPanel WindowOpenPanel
#endif
Expand All @@ -219,7 +219,7 @@ IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, MAYBE_WindowOpenPanel) {
#if defined(USE_ASH)
// On Ash, this currently fails because we're currently opening new panel
// windows as popup windows instead.
#define MAYBE_WindowOpenPanelDetached FAILS_WindowOpenPanelDetached
#define MAYBE_WindowOpenPanelDetached DISABLED_WindowOpenPanelDetached
#else
#define MAYBE_WindowOpenPanelDetached WindowOpenPanelDetached
#endif
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/prerender/prerender_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1290,7 +1290,7 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderNaClPluginDisabled) {
#elif defined(OS_MACOSX)
// http://crbug.com/100514
#define MAYBE_PrerenderIframeDelayLoadPlugin \
FAILS_PrerenderIframeDelayLoadPlugin
DISABLED_PrerenderIframeDelayLoadPlugin
#else
#define MAYBE_PrerenderIframeDelayLoadPlugin PrerenderIframeDelayLoadPlugin
#endif
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/process_singleton_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class ProcessSingletonTest : public InProcessBrowserTest {

#if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)
// http://crbug.com/58219
#define MAYBE_StartupRaceCondition FAILS_StartupRaceCondition
#define MAYBE_StartupRaceCondition DISABLED_StartupRaceCondition
#else
#define MAYBE_StartupRaceCondition StartupRaceCondition
#endif
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientThemesSyncTest, CustomTheme) {

// TODO(sync): Fails on Chrome OS. See http://crbug.com/84575.
#if defined(OS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(SingleClientThemesSyncTest, FAILS_NativeTheme) {
IN_PROC_BROWSER_TEST_F(SingleClientThemesSyncTest, DISABLED_NativeTheme) {
#else
IN_PROC_BROWSER_TEST_F(SingleClientThemesSyncTest, NativeTheme) {
#endif // OS_CHROMEOS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, CustomTheme) {
// TCM ID - 3599303.
// TODO(sync): Fails on Chrome OS. See http://crbug.com/84575.
#if defined(OS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, FAILS_NativeTheme) {
IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, DISABLED_NativeTheme) {
#else
IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, NativeTheme) {
#endif // OS_CHROMEOS
Expand Down Expand Up @@ -107,7 +107,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, DefaultTheme) {
// TCM ID - 7292065.
// TODO(sync): Fails on Chrome OS. See http://crbug.com/84575.
#if defined(OS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, FAILS_NativeDefaultRace) {
IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, DISABLED_NativeDefaultRace) {
#else
IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, NativeDefaultRace) {
#endif // OS_CHROMEOS
Expand All @@ -132,7 +132,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, NativeDefaultRace) {
// TCM ID - 7294077.
// TODO(sync): Fails on Chrome OS. See http://crbug.com/84575.
#if defined(OS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, FAILS_CustomNativeRace) {
IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, DISABLED_CustomNativeRace) {
#else
IN_PROC_BROWSER_TEST_F(TwoClientThemesSyncTest, CustomNativeRace) {
#endif // OS_CHROMEOS
Expand Down
4 changes: 2 additions & 2 deletions chrome/browser/task_manager/task_manager_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeTabContentsChanges) {
#if defined(USE_ASH)
// This test fails on Ash because task manager treats view type
// Panels differently for Ash.
#define MAYBE_NoticePanelChanges FAILS_NoticePanelChanges
#define MAYBE_NoticePanelChanges DISABLED_NoticePanelChanges
#else
#define MAYBE_NoticePanelChanges NoticePanelChanges
#endif
Expand Down Expand Up @@ -256,7 +256,7 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, KillBGContents) {
#if defined(USE_ASH)
// This test fails on Ash because task manager treats view type
// Panels differently for Ash.
#define MAYBE_KillPanelExtension FAILS_KillPanelExtension
#define MAYBE_KillPanelExtension DISABLED_KillPanelExtension
#else
#define MAYBE_KillPanelExtension KillPanelExtension
#endif
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/ui/browser_focus_uitest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ using content::WebContents;
#if defined(OS_LINUX) || defined(OS_MACOSX)
// TODO(jcampan): http://crbug.com/23683 for linux.
// TODO(suzhe): http://crbug.com/49737 for mac.
#define MAYBE_TabsRememberFocusFindInPage FAILS_TabsRememberFocusFindInPage
#define MAYBE_TabsRememberFocusFindInPage DISABLED_TabsRememberFocusFindInPage
#elif defined(OS_WIN)
// Flaky, http://crbug.com/62537.
#define MAYBE_TabsRememberFocusFindInPage DISABLED_TabsRememberFocusFindInPage
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ IN_PROC_BROWSER_TEST_F(
#if defined(OS_MACOSX)
// http://crbug.com/100467
IN_PROC_BROWSER_TEST_F(
FullscreenControllerTest, FAILS_TabEntersPresentationModeFromWindowed) {
FullscreenControllerTest, DISABLED_TabEntersPresentationModeFromWindowed) {
ASSERT_TRUE(test_server()->Start());

AddTabAtIndexAndWait(
Expand Down
4 changes: 2 additions & 2 deletions chrome/browser/ui/webui/web_ui_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ WebUIBrowserTest* WebUIBrowserExpectFailTest::s_test_ = NULL;
IN_PROC_BROWSER_TEST_F(WebUIBrowserExpectFailTest, TestFailsFast) {
AddLibrary(FilePath(FILE_PATH_LITERAL("sample_downloads.js")));
ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));
EXPECT_FATAL_FAILURE(RunJavascriptTestNoReturn("FAILS_BogusFunctionName"),
EXPECT_FATAL_FAILURE(RunJavascriptTestNoReturn("DISABLED_BogusFunctionName"),
"WebUITestHandler::Observe");
}

Expand All @@ -534,7 +534,7 @@ IN_PROC_BROWSER_TEST_F(WebUIBrowserExpectFailTest, TestFailsAsyncFast) {
AddLibrary(FilePath(FILE_PATH_LITERAL("sample_downloads.js")));
ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));
EXPECT_FATAL_FAILURE(
RunJavascriptAsyncTestNoReturn("FAILS_BogusFunctionName"),
RunJavascriptAsyncTestNoReturn("DISABLED_BogusFunctionName"),
"WebUITestHandler::Observe");
}

Expand Down
2 changes: 1 addition & 1 deletion chrome/common/service_process_util_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
#if defined(USE_AURA)
// This test fails http://crbug.com/84854, and is very flaky on CrOS and
// somewhat flaky on other Linux.
#define MAYBE_ForceShutdown FAILS_ForceShutdown
#define MAYBE_ForceShutdown DISABLED_ForceShutdown
#else
#if defined(OS_LINUX) || defined(OS_WIN)
#define MAYBE_ForceShutdown DISABLED_ForceShutdown
Expand Down
2 changes: 1 addition & 1 deletion chrome/test/data/webui/sample_downloads.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function testAssertFalse() {
assertFalse(false);
}

function FAILS_testAssertFalse() {
function DISABLED_testAssertFalse() {
assertFalse(true);
assertFalse(false);
}
Expand Down
4 changes: 2 additions & 2 deletions chrome/test/perf/dom_checker_uitest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ class DomCheckerTest : public UITest {
};

// Always fails, see but http://crbug.com/21321
TEST_F(DomCheckerTest, FAILS_File) {
TEST_F(DomCheckerTest, DISABLED_File) {
if (!CommandLine::ForCurrentProcess()->HasSwitch(kRunDomCheckerTest))
return;

Expand All @@ -243,7 +243,7 @@ TEST_F(DomCheckerTest, FAILS_File) {
// expected results file that didn't exist. Fixing that bug revealed
// that the expected results weren't correct anyway.
// http://crbug.com/21321
TEST_F(DomCheckerTest, FAILS_Http) {
TEST_F(DomCheckerTest, DISABLED_Http) {
if (!CommandLine::ForCurrentProcess()->HasSwitch(kRunDomCheckerTest))
return;

Expand Down
4 changes: 2 additions & 2 deletions chrome/test/perf/tab_switching_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,12 @@ class TabSwitchingUITest : public UIPerfTest {
// This is failing, and taking forever to finish when doing so.
// http://crbug.com/102162

TEST_F(TabSwitchingUITest, FAILS_TabSwitch) {
TEST_F(TabSwitchingUITest, DISABLED_TabSwitch) {
RunTabSwitchingUITest("t", true);
}

// Started failing with a webkit roll in r49936. See http://crbug.com/46751
TEST_F(TabSwitchingUITest, FAILS_TabSwitchRef) {
TEST_F(TabSwitchingUITest, DISABLED_TabSwitchRef) {
UseReferenceBuild();
RunTabSwitchingUITest("t_ref", true);
}
Expand Down
2 changes: 1 addition & 1 deletion chrome_frame/test/test_with_web_server.cc
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ class UaTemplateFileResponse : public test_server::FileResponse {
//
// This test currently fails because GCF does not add the chromeframe header
// to requests that mshtml initiates via IInternetSession::CreateBinding.
TEST_F(ChromeFrameTestWithWebServer, FAILS_FullTabModeIE_RefreshMshtmlTest) {
TEST_F(ChromeFrameTestWithWebServer, DISABLED_FullTabModeIE_RefreshMshtmlTest) {
const wchar_t* kPages[] = {
L"mshtml_refresh_test.html",
L"mshtml_refresh_test_popup.html",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -825,7 +825,7 @@ TEST_F(RenderWidgetHostTest, PaintAtSize) {

// Fails on Linux Aura, see http://crbug.com/100344
#if defined(USE_AURA) && !defined(OS_WIN)
#define MAYBE_HandleKeyEventsWeSent FAILS_HandleKeyEventsWeSent
#define MAYBE_HandleKeyEventsWeSent DISABLED_HandleKeyEventsWeSent
#else
#define MAYBE_HandleKeyEventsWeSent HandleKeyEventsWeSent
#endif
Expand Down
4 changes: 2 additions & 2 deletions ui/base/events/event_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ TEST(EventTest, Repeated) {

// Bug 99129.
#if defined(USE_AURA)
#define MAYBE_KeyEvent FAILS_KeyEvent
#define MAYBE_KeyEventDirectUnicode FAILS_KeyEventDirectUnicode
#define MAYBE_KeyEvent DISABLED_KeyEvent
#define MAYBE_KeyEventDirectUnicode DISABLED_KeyEventDirectUnicode
#else
#define MAYBE_KeyEvent KeyEvent
#define MAYBE_KeyEventDirectUnicode KeyEventDirectUnicode
Expand Down
Loading

0 comments on commit e00ccc9

Please sign in to comment.