Skip to content

Commit

Permalink
Revert of [Mac] Remove unnecessary button on 'Bookmark all tabs' wind…
Browse files Browse the repository at this point in the history
…ow (patchset #2 id:20001 of https://codereview.chromium.org/583633002/)

Reason for revert:
Nonono you can't just hack out lines from xib files! https://codereview.chromium.org/586543002/ rebuilds the xib file in Xcode to accomplish this and more.

Original issue's description:
> [Mac] Remove unnecessary button on 'Bookmark all tabs' window
>
> Remove unnecessary button on 'Bookmark all tabs' window which appears
> before "Bookmarks Bar"
> XIB Changes:
> Removing the line in the following .xib file which is responsible for the appearance of empty button.
> chrome/app/nibs/BookmarkAllTabs.xib
>
> BUG=415554
> R=asvitkine@chromium.org
>
> TEST=
> 1) Launch chrome, open 2-3 tabs.
> 2) Right click on last tab and select 'Bookmark all tabs'
> 3) Empty button shouldn't be shown.
>
> Committed: https://crrev.com/0ce925fc1ee0f53142313d1b63b32dafbeeeaace
> Cr-Commit-Position: refs/heads/master@{#295714}

TBR=asvitkine@chromium.org,shilpa.shri@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=415554

Review URL: https://codereview.chromium.org/592833002

Cr-Commit-Position: refs/heads/master@{#295976}
  • Loading branch information
avi authored and Commit bot committed Sep 22, 2014
1 parent 8d3a769 commit d9ab677
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,6 @@ ShankarGanesh K <blr.bmlab@gmail.com>
Shez Baig <sbaig1@bloomberg.net>
Shiliu Wang <aofdwsl@gmail.com>
Shiliu Wang <shiliu.wang@intel.com>
Shilpa Shri <shilpa.shri@samsung.com>
Shouqun Liu <shouqun.liu@intel.com>
Shreeram Kushwaha <shreeram.k@samsung.com>
Shreyas Gopal <shreyas.g@samsung.com>
Expand Down
1 change: 1 addition & 0 deletions chrome/app/nibs/BookmarkAllTabs.xib
Original file line number Diff line number Diff line change
Expand Up @@ -832,6 +832,7 @@
<reference key="object" ref="607350872"/>
<object class="NSMutableArray" key="children">
<bool key="EncodedWithXMLCoder">YES</bool>
<reference ref="329152418"/>
<reference ref="904735886"/>
<reference ref="792927203"/>
<reference ref="316831958"/>
Expand Down

0 comments on commit d9ab677

Please sign in to comment.