Skip to content

Commit

Permalink
Removing onBookmarkChanged notification to application on history change
Browse files Browse the repository at this point in the history
and added proper history change notification on history data change.

BUG=None

Review URL: https://codereview.chromium.org/579753002

Cr-Commit-Position: refs/heads/master@{#295651}
  • Loading branch information
kn.darshini authored and Commit bot committed Sep 19, 2014
1 parent 7abfb91 commit cd15c85
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ Daniel Johnson <danielj41@gmail.com>
Daniel Nishi <dhnishi@gmail.com>
Daniel Shaulov <dshaulov@ptc.com>
Daniel Trebbien <dtrebbien@gmail.com>
Darshini KN <kn.darshini@samsung.com>
David Benjamin <davidben@mit.edu>
David Erceg <erceg.david@gmail.com>
David Futcher <david.mike.futcher@gmail.com>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1044,6 +1044,11 @@ private void onBookmarkChanged() {
notifyChange(buildAPIContentUri(getContext(), BOOKMARKS_PATH));
}

@CalledByNative
private void onHistoryChanged() {
notifyChange(buildAPIContentUri(getContext(), HISTORY_PATH));
}

@CalledByNative
private void onSearchTermChanged() {
notifyChange(buildAPIContentUri(getContext(), SEARCHES_PATH));
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/android/provider/chrome_browser_provider.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1613,7 +1613,7 @@ void ChromeBrowserProvider::Observe(
ScopedJavaLocalRef<jobject> obj = weak_java_provider_.get(env);
if (obj.is_null())
return;
Java_ChromeBrowserProvider_onBookmarkChanged(env, obj.obj());
Java_ChromeBrowserProvider_onHistoryChanged(env, obj.obj());
} else if (type ==
chrome::NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED) {
JNIEnv* env = AttachCurrentThread();
Expand Down

0 comments on commit cd15c85

Please sign in to comment.