Skip to content

Commit

Permalink
Remove trailing commas from Chromium IDLs
Browse files Browse the repository at this point in the history
This removes trailing commas in extended attributes from the
2 files that have them.
This is not part of the standard, and doesn't work with strict
parsers, but laxer parsers may not notice.
This removes a barrier to using more standard-compliant parsers
more widely; discovered when rewriting Blink IDL parser.

BUG=242800

Review URL: https://chromiumcodereview.appspot.com/15679004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201779 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
nbarth@chromium.org committed May 23, 2013
1 parent c635146 commit b1954f5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion chrome_frame/chrome_tab.idl
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ interface IChromeFrame : IDispatch {
uuid(E98FDFD9-312B-444a-A640-8E88F3CC08B8),
oleautomation,
nonextensible,
hidden,
hidden
]
// Internal implementation interface. Not intended as an API. May change
// frequently, don't treat this as frozen.
Expand Down
12 changes: 6 additions & 6 deletions google_update/google_update_idl.idl
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ interface ICurrentState : IDispatch {
dual,
uuid(4E223325-C16B-4eeb-AEDC-19AA99A237FA),
helpstring("IRegistrationUpdateHook Interface"),
pointer_default(unique),
pointer_default(unique)
]
interface IRegistrationUpdateHook : IDispatch {
HRESULT UpdateRegistry([in] BSTR app_id, [in] VARIANT_BOOL is_machine);
Expand All @@ -487,7 +487,7 @@ interface IRegistrationUpdateHook : IDispatch {
object,
uuid(b3a47570-0a85-4aea-8270-529d47899603),
helpstring("ICredentialDialog Interface"),
pointer_default(unique),
pointer_default(unique)
]
interface ICredentialDialog : IUnknown {
HRESULT QueryUserForCredentials([in] ULONG_PTR owner_hwnd,
Expand All @@ -508,7 +508,7 @@ interface ICredentialDialog : IUnknown {
dual,
uuid(494B20CF-282E-4BDD-9F5D-B70CB09D351E),
helpstring("IGoogleUpdate3Web Interface"),
pointer_default(unique),
pointer_default(unique)
]
interface IGoogleUpdate3Web : IDispatch {
HRESULT createAppBundleWeb([out, retval] IDispatch** app_bundle_web);
Expand All @@ -518,7 +518,7 @@ interface IGoogleUpdate3Web : IDispatch {
object,
uuid(2D363682-561D-4c3a-81C6-F2F82107562A),
helpstring("IGoogleUpdate3WebSecurity Interface"),
pointer_default(unique),
pointer_default(unique)
]
interface IGoogleUpdate3WebSecurity : IUnknown {
HRESULT setOriginURL([in] BSTR origin_url);
Expand All @@ -529,7 +529,7 @@ interface IGoogleUpdate3WebSecurity : IUnknown {
dual,
uuid(DD42475D-6D46-496a-924E-BD5630B4CBBA),
helpstring("IAppBundleWeb Interface"),
pointer_default(unique),
pointer_default(unique)
]
interface IAppBundleWeb : IDispatch {
[id(2)] HRESULT createApp([in] BSTR app_guid,
Expand Down Expand Up @@ -568,7 +568,7 @@ interface IAppBundleWeb : IDispatch {
dual,
uuid(18D0F672-18B4-48e6-AD36-6E6BF01DBBC4),
helpstring("IAppWeb Interface"),
pointer_default(unique),
pointer_default(unique)
]
interface IAppWeb : IDispatch {
[propget] HRESULT appId([out, retval] BSTR*);
Expand Down

0 comments on commit b1954f5

Please sign in to comment.