Skip to content

Commit

Permalink
Improve MessageLoop's comments.
Browse files Browse the repository at this point in the history
Remove incorrect mention of RefCountedThreadSafe from DeleteSoon's
comment.

Replace mention of PostDelayedTask with ReleaseSoon in ReleaseSoon's
comment.

BUG=

Review URL: https://codereview.chromium.org/615693002

Cr-Commit-Position: refs/heads/master@{#297870}
  • Loading branch information
maniscalco authored and Commit bot committed Oct 2, 2014
1 parent 4224304 commit 9be04f0
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions base/message_loop/message_loop.h
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,7 @@ class BASE_EXPORT MessageLoop : public MessagePump::Delegate {
// good).
//
// NOTE: This method may be called on any thread. The object will be deleted
// on the thread that executes MessageLoop::Run(). If this is not the same
// as the thread that calls PostDelayedTask(FROM_HERE, ), then T MUST inherit
// from RefCountedThreadSafe<T>!
// on the thread that executes MessageLoop::Run().
template <class T>
void DeleteSoon(const tracked_objects::Location& from_here, const T* object) {
base::subtle::DeleteHelperInternal<T, void>::DeleteViaSequencedTaskRunner(
Expand All @@ -223,7 +221,7 @@ class BASE_EXPORT MessageLoop : public MessagePump::Delegate {
// NOTE: This method may be called on any thread. The object will be
// released (and thus possibly deleted) on the thread that executes
// MessageLoop::Run(). If this is not the same as the thread that calls
// PostDelayedTask(FROM_HERE, ), then T MUST inherit from
// ReleaseSoon(FROM_HERE, ), then T MUST inherit from
// RefCountedThreadSafe<T>!
template <class T>
void ReleaseSoon(const tracked_objects::Location& from_here,
Expand Down

0 comments on commit 9be04f0

Please sign in to comment.