Skip to content

Commit

Permalink
Removes some unnecessary preprocessor directives
Browse files Browse the repository at this point in the history
The removed conditions are already satisfied through their respective
enclosing conditions.

Review URL: https://codereview.chromium.org/138213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245003 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
cimamoglu@chromium.org committed Jan 15, 2014
1 parent 1bc659c commit 8a75828
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 19 deletions.
4 changes: 0 additions & 4 deletions chrome/browser/ui/webui/options/browser_options_handler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1516,8 +1516,6 @@ void BrowserOptionsHandler::VirtualKeyboardChangeCallback(
chromeos::accessibility::EnableVirtualKeyboard(enabled);
}

#if defined(OS_CHROMEOS)

void BrowserOptionsHandler::PerformFactoryResetRestart(
const base::ListValue* args) {
if (g_browser_process->browser_policy_connector()->IsEnterpriseManaged())
Expand All @@ -1532,8 +1530,6 @@ void BrowserOptionsHandler::PerformFactoryResetRestart(
chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->RequestRestart();
}

#endif

void BrowserOptionsHandler::SetupAccessibilityFeatures() {
PrefService* pref_service = g_browser_process->local_state();
base::FundamentalValue virtual_keyboard_enabled(
Expand Down
2 changes: 0 additions & 2 deletions chrome/browser/ui/webui/sync_setup_handler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -769,9 +769,7 @@ void SyncSetupHandler::HandleStartSignin(const base::ListValue* args) {
void SyncSetupHandler::HandleStopSyncing(const base::ListValue* args) {
if (GetSyncService())
ProfileSyncService::SyncEvent(ProfileSyncService::STOP_FROM_OPTIONS);
#if !defined(OS_CHROMEOS)
SigninManagerFactory::GetForProfile(GetProfile())->SignOut();
#endif
}
#endif

Expand Down
2 changes: 0 additions & 2 deletions content/plugin/webplugin_delegate_stub.cc
Original file line number Diff line number Diff line change
Expand Up @@ -345,9 +345,7 @@ void WebPluginDelegateStub::OnImeCompositionUpdated(
int cursor_position) {
if (delegate_)
delegate_->ImeCompositionUpdated(text, clauses, target, cursor_position);
#if defined(OS_WIN) && !defined(USE_AURA)
webplugin_->UpdateIMEStatus();
#endif
}

void WebPluginDelegateStub::OnImeCompositionCompleted(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ namespace content {
#if defined(ENABLE_WEBRTC)
namespace {

#if defined(ENABLE_WEBRTC)
bool CanUseMediaStreamAPI(const RendererPpapiHost* host,
PP_Instance instance) {
blink::WebPluginContainer* container =
Expand All @@ -53,7 +52,6 @@ bool CanUseMediaStreamAPI(const RendererPpapiHost* host,
GetContentClient()->renderer();
return content_renderer_client->AllowPepperMediaStreamAPI(document_url);
}
#endif // defined(ENABLE_WEBRTC)

} // namespace
#endif // defined(ENABLE_WEBRTC)
Expand Down
2 changes: 0 additions & 2 deletions content/renderer/render_view_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5962,12 +5962,10 @@ bool RenderViewImpl::openDateTimeChooser(
return date_time_picker_client_->Open();
}

#if defined(OS_ANDROID)
void RenderViewImpl::DismissDateTimeDialog() {
DCHECK(date_time_picker_client_);
date_time_picker_client_.reset(NULL);
}
#endif

WebMediaPlayer* RenderViewImpl::CreateAndroidWebMediaPlayer(
WebFrame* frame,
Expand Down
5 changes: 0 additions & 5 deletions rlz/lib/financial_ping.cc
Original file line number Diff line number Diff line change
Expand Up @@ -211,15 +211,10 @@ void FinancialPingUrlFetcherDelegate::OnURLFetchComplete(
callback_.Run();
}

#if defined(RLZ_NETWORK_IMPLEMENTATION_CHROME_NET)
bool send_financial_ping_interrupted_for_test = false;
#endif

} // namespace

#endif

#if defined(RLZ_NETWORK_IMPLEMENTATION_CHROME_NET)
void ShutdownCheck(base::WeakPtr<base::RunLoop> weak) {
if (!weak.get())
return;
Expand Down
2 changes: 0 additions & 2 deletions ui/views/controls/textfield/textfield_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -902,14 +902,12 @@ TEST_F(TextfieldTest, DragAndDrop_AcceptDrop) {
// Ensure that textfields do not accept non-OSExchangeData::STRING types.
ui::OSExchangeData bad_data;
bad_data.SetFilename(base::FilePath(FILE_PATH_LITERAL("x")));
#if defined(OS_WIN)
ui::OSExchangeData::CustomFormat fmt = ui::Clipboard::GetBitmapFormatType();
bad_data.SetPickledData(fmt, Pickle());
bad_data.SetFileContents(base::FilePath(L"x"), "x");
bad_data.SetHtml(base::string16(ASCIIToUTF16("x")), GURL("x.org"));
ui::OSExchangeData::DownloadFileInfo download(base::FilePath(), NULL);
bad_data.SetDownloadFileInfo(download);
#endif
EXPECT_FALSE(textfield_->CanDrop(bad_data));
}
#endif
Expand Down

0 comments on commit 8a75828

Please sign in to comment.