Skip to content

Commit

Permalink
Changing in the intialization order of WeakPtrFactory in content/brow…
Browse files Browse the repository at this point in the history
…ser module

such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/589463002

Cr-Commit-Position: refs/heads/master@{#298383}
  • Loading branch information
krish.botta authored and Commit bot committed Oct 7, 2014
1 parent aec97a0 commit 875dc1f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ Kihong Kwon <kihong.kwon@samsung.com>
Kim Christensen <kimworking@gmail.com>
Kingshuk Jana <kingshuk.j@samsung.com>
Klemen Forstnerič <klemen.forstneric@gmail.com>
Krishna Chaitanya <krish.botta@samsung.com>
Krzysztof Wolanski <k.wolanski@samsung.com>
Kunal Thakar <kunalt@gmail.com>
Kushal Pisavadia <kushi.p@gmail.com>
Expand Down
4 changes: 2 additions & 2 deletions content/browser/renderer_host/gpu_message_filter.h
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ class GpuMessageFilter : public BrowserMessageFilter {

scoped_refptr<RenderWidgetHelper> render_widget_helper_;

base::WeakPtrFactory<GpuMessageFilter> weak_ptr_factory_;

typedef std::vector<linked_ptr<FrameSubscription> > FrameSubscriptionList;
FrameSubscriptionList frame_subscription_list_;

base::WeakPtrFactory<GpuMessageFilter> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(GpuMessageFilter);
};

Expand Down

0 comments on commit 875dc1f

Please sign in to comment.