Skip to content

Commit

Permalink
Rename extension action context menu option string "Manage" to "Manag…
Browse files Browse the repository at this point in the history
…ed Extensions"

When right click on an extension browser action in the Omnibox, the contextual
drop down says "Manage", which is unclear. Make the string to be more specific
such as "Manage Extensions".
The string's casing matches the platform; i.e. "Managed Extensions" for Mac,
"Managed extensions" everywhere else.

grd file changes:
Modifying 1 line label and 1 line desc text each in title case and in non title
case responsible for the label in: chrome/app/generated_resources.grd

BUG=418691
R=rouslan@chromium.org

TEST=
1) Launch chrome and install few extensions.
2) Right click an extension and observe
3) The context menu option for managing extensions should be string
   "Managed Extensions" on MAC, "Managed extensions" everywhere else.

Review URL: https://codereview.chromium.org/659663004

Cr-Commit-Position: refs/heads/master@{#300516}
  • Loading branch information
shilpashri authored and Commit bot committed Oct 21, 2014
1 parent cff7ec2 commit 4b4b173
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@ ShankarGanesh K <blr.bmlab@gmail.com>
Shez Baig <sbaig1@bloomberg.net>
Shiliu Wang <aofdwsl@gmail.com>
Shiliu Wang <shiliu.wang@intel.com>
Shilpa Shri <shilpa.shri@samsung.com>
Shouqun Liu <shouqun.liu@intel.com>
Shreeram Kushwaha <shreeram.k@samsung.com>
Shreyas Gopal <shreyas.g@samsung.com>
Expand Down
8 changes: 4 additions & 4 deletions chrome/app/generated_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -4885,8 +4885,8 @@ Make sure you do not expose any sensitive information.
<message name="IDS_EXTENSIONS_HIDE_BUTTON" desc="The text for the Hide context menu item (sentence case).">
Hide button
</message>
<message name="IDS_MANAGE_EXTENSION" desc="The 'Manage' text in the context menu for when right-clicking on extension icons (sentence case).">
Manage
<message name="IDS_MANAGE_EXTENSION" desc="The 'Managed extensions' text in the context menu for when right-clicking on extension icons (sentence case).">
Managed extensions
</message>
<message name="IDS_EXTENSION_ACTION_INSPECT_POPUP" desc="The text for the right-click menu of page and browser actions which shows the popup and opens the developer tools (sentence case).">
Inspect popup
Expand All @@ -4905,8 +4905,8 @@ Make sure you do not expose any sensitive information.
<message name="IDS_EXTENSIONS_HIDE_BUTTON" desc="The text for the Hide context menu item (title case).">
Hide Button
</message>
<message name="IDS_MANAGE_EXTENSION" desc="The 'Manage' text in the context menu for when right-clicking on extension icons (title case).">
Manage
<message name="IDS_MANAGE_EXTENSION" desc="The 'Managed Extensions' text in the context menu for when right-clicking on extension icons (title case).">
Managed Extensions
</message>
<message name="IDS_EXTENSION_ACTION_INSPECT_POPUP" desc="The text for the right-click menu of page and browser actions which shows the popup and opens the developer tools (title case).">
Inspect Popup
Expand Down

0 comments on commit 4b4b173

Please sign in to comment.