Skip to content

Commit

Permalink
On tapping the disabled option in context menu should not close the menu
Browse files Browse the repository at this point in the history
In the context menu, disabled items are not required so can be removed
instead of disabling them, so user donot tap on it.

BUG=395551

Review URL: https://codereview.chromium.org/494093003

Cr-Commit-Position: refs/heads/master@{#291861}
  • Loading branch information
divya.bansal authored and Commit bot committed Aug 26, 2014
1 parent ececc5a commit 0ab900d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ Derek Halman <d.halman@gmail.com>
Devlin Cronin <rdevlin.cronin@gmail.com>
Diego Ferreiro Val <elfogris@gmail.com>
Dillon Sellars <dill.sellars@gmail.com>
Divya Bansal <divya.bansal@samsung.com>
Dominic Jodoin <dominic.jodoin@gmail.com>
Dominik Röttsches <dominik.rottsches@intel.com>
Don Woodward <woodward@adobe.com>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@ public void buildContextMenu(ContextMenu menu, Context context, ContextMenuParam
menu.findItem(R.id.contextmenu_copy_link_text).setVisible(false);
}

menu.findItem(R.id.contextmenu_save_link_as).setEnabled(
menu.findItem(R.id.contextmenu_save_link_as).setVisible(
UrlUtilities.isDownloadableScheme(params.getLinkUrl()));

if (params.isVideo()) {
menu.findItem(R.id.contextmenu_save_video).setEnabled(
menu.findItem(R.id.contextmenu_save_video).setVisible(
UrlUtilities.isDownloadableScheme(params.getSrcUrl()));
} else if (params.isImage()) {
menu.findItem(R.id.contextmenu_save_image).setEnabled(
menu.findItem(R.id.contextmenu_save_image).setVisible(
UrlUtilities.isDownloadableScheme(params.getSrcUrl()));

if (mDelegate.canLoadOriginalImage()) {
Expand Down

0 comments on commit 0ab900d

Please sign in to comment.