Skip to content

Conversation

@TheRustyPickle
Copy link
Contributor

@TheRustyPickle TheRustyPickle commented Apr 30, 2023

let slack_channel_message = match config.get_slack_channel() {
Some(_) => Report::new("O", "slack_channel"),
None => Report::new("X", "slack_channel")
.update_reason(&ConfigurationError::SlackConfigNotFound),
};
let slack_token_message = match config.get_slack_channel() {

@24seconds 24seconds self-requested a review May 3, 2023 07:23
@24seconds 24seconds added bug Something isn't working enhancement New feature or request labels May 3, 2023
Copy link
Owner

@24seconds 24seconds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

};

let slack_token_message = match config.get_slack_channel() {
let slack_token_message = match config.get_slack_token() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!!

@24seconds 24seconds merged commit 2ebb2b9 into 24seconds:main May 3, 2023
@TheRustyPickle TheRustyPickle deleted the update-config-report branch May 3, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[improvement] Generate config report considering newly added configurations

2 participants