Remove blank excludes flag (istio#7809)

249043822 · Aug 11, 2018 · cd4e7c6 · cd4e7c6
1 parent 9ca6659
commit cd4e7c6
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/tools/run_shellcheck.sh b/tools/run_shellcheck.sh
@@ -5,11 +5,6 @@
 TOOLS_DIR="$(cd "$(dirname "${0}")" && pwd -P)"
 ISTIO_ROOT="$(cd "$(dirname "${TOOLS_DIR}")" && pwd -P)"
 
-# Set global rule exclusions here, separated by comma (e.g. SC1090,SC1091).
-# See https://github.com/koalaman/shellcheck/wiki for details on each code's
-# corresponding rule.
-EXCLUDES=""
-
 # All files ending in .sh.
 SH_FILES=$( \
     find "${ISTIO_ROOT}" \
@@ -26,5 +21,9 @@ SHEBANG_FILES=$( \
             head -n 1 "$f" | grep -q '^#!.*sh' && echo "$f";
         done)
 
+# Set global rule exclusions with the "excludes" flag, separated by comma (e.g.
+# "--excludes=SC1090,SC1091"). See https://github.com/koalaman/shellcheck/wiki
+# for details on each code's corresponding rule.
+
 echo "${SH_FILES}" "${SHEBANG_FILES}" \
-    | xargs shellcheck --exclude="${EXCLUDES}"
+    | xargs shellcheck