Skip to content

Conversation

@manit815
Copy link

@manit815 manit815 commented Apr 3, 2023

At present, the current regex doesn't take care of when we are passing filenames having chinese characters.

The bug reproduction steps:
Take three files with names as "平行级_高速轴_中间_001.xml", "平行级_高速轴_叶片侧_001.xml", "平行级_高速轴_电机侧_001.xml" and perform an upload. The uniqueIdentifier was not getting generated, like below:

image

As a fix for this, we have started respecting chinese characters(unicode) in the regex.

@dmares01
Copy link

Since this repo is no longer active I have created a new fork here https://github.com/augustcodes08/resumable-uploads that I will be actively developing. If you are okay with it @manit815 I am going to make these changes in my fork as well. If you would like to keep the commit ownership and be a contributor please feel free to open a PR on that repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants