Better commonJs module integration #397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small fix allows better integration with commonJS module system and reflects it in TS definition.
Initially I've started to hacking it because of issue similar to #383. Workaround that proposed there breaks typings system. Unfortunately there is no small fix for types when project is compiled using webpack (and angular CLI) that provides good programming experience.
This fix also will provide better usage for ES6+ users, because it allows next syntax:
Which is valid in both ES6+ and TS.
NOTES:
defaultimport for using it asimport Resumable from 'resumablejs';d.tsfiles when publish this package tonpm, so TS users won't have to explicitly add additional dependency for typings. In this case typings would be always up-to-date.