Skip to content

Conversation

@Igmat
Copy link
Contributor

@Igmat Igmat commented Aug 10, 2017

This small fix allows better integration with commonJS module system and reflects it in TS definition.
Initially I've started to hacking it because of issue similar to #383. Workaround that proposed there breaks typings system. Unfortunately there is no small fix for types when project is compiled using webpack (and angular CLI) that provides good programming experience.

This fix also will provide better usage for ES6+ users, because it allows next syntax:

import { Resumable } from 'resumablejs';

Which is valid in both ES6+ and TS.

NOTES:

  1. We could probably also add default import for using it as import Resumable from 'resumablejs';
  2. It also will be great if you won't exclude d.ts files when publish this package to npm, so TS users won't have to explicitly add additional dependency for typings. In this case typings would be always up-to-date.

@saberone
Copy link

Pretty please with sugar on top. Can this be merged. I currently have a dependency on the github reop of @Igmat (props for the fix), and it seems to work fine.

@steffentchr steffentchr merged commit 5b29bca into 23:master Aug 21, 2018
@steffentchr
Copy link
Member

Sounds good, sorry for missing in the first go-around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants