fix order of operations bug with duplicate files in one drag/drop #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffentchr
added a commit
that referenced
this pull request
Mar 25, 2015
fix order of operations bug with duplicate files in one drag/drop
Member
|
Looks good, merging. Thanks @benjamincarp. |
Author
|
Dang you're fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could add multiple files to the files array that had the same unique identifier if there were 2 files of the same name and size inside a single folder and it's subfolders if you dragged the parent folder into your resumable drop zone.
This was because files were being added to the files array inside the setTimeout that wraps the fileAdded event trigger. That meant files would be hitting the
if (!$.getFromUniqueIdentifier(uniqueIdentifier))check before previous files were actually added to the array.