Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.24.2 Upgrade - Fixed all compiler Errors and Warnings. #833

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

4.24.2 Upgrade - Fixed all compiler Errors and Warnings. #833

wants to merge 9 commits into from

Conversation

SaxonRah
Copy link

I ran the editor for over eight hours, no crashes.
Ran a bunch of Python scripts. Nothing seemed to be broken.

OS: Windows 10
Python: 3.6.0

@riandrake
Copy link

Thanks for this! I did see two warnings when compiling though:

2>UEPyActor.cpp(798): warning C4996: 'AActor::GetComponentsByClass': Use one of the GetComponents implementations as appropriate Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
2>  C:\Program Files\Epic Games\UE_4.24\Engine\Source\Runtime\Engine\Classes\GameFramework/Actor.h(2881): note: see declaration of 'AActor::GetComponentsByClass'

2>UEPySTextBlock.cpp(14): warning C4996: 'STextBlock::SetText': SetText taking FString is deprecated. Use the FText version instead Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
2>  C:\Program Files\Epic Games\UE_4.24\Engine\Source\Runtime\Slate\Public\Widgets/Text/STextBlock.h(171): note: see declaration of 'STextBlock::SetText'

@SaxonRah
Copy link
Author

SaxonRah commented Feb 17, 2020 •
edited
Loading

Thanks for this! I did see two warnings when compiling though:

2>UEPyActor.cpp(798): warning C4996: 'AActor::GetComponentsByClass': Use one of the GetComponents implementations as appropriate Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
2>  C:\Program Files\Epic Games\UE_4.24\Engine\Source\Runtime\Engine\Classes\GameFramework/Actor.h(2881): note: see declaration of 'AActor::GetComponentsByClass'

2>UEPySTextBlock.cpp(14): warning C4996: 'STextBlock::SetText': SetText taking FString is deprecated. Use the FText version instead Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
2>  C:\Program Files\Epic Games\UE_4.24\Engine\Source\Runtime\Slate\Public\Widgets/Text/STextBlock.h(171): note: see declaration of 'STextBlock::SetText'

No, Thank you! I wasn't completely sure if my compilation was missing some of the warnings, looks like my suspicion was correct! I'll fix em up soon and update the PR.

@HarryMolina
Copy link

HarryMolina commented Feb 21, 2020 via email

@Adanteh
Copy link

Adanteh commented Mar 15, 2020

Is this supposed to be launchable now? New to this and only tried the 4.24 version.

Plugins/UnrealEnginePython/Source/UnrealEnginePython/Private/Slate/UEPyFMenuBuilder.cpp(2): fatal error C1083: Cannot open include file: 'IAssetTools.h': No such file or directory
Seems like it's preventing me from launching.

@gschweig-amz
Copy link

bind_event lets the engine crash !

@gschweig-amz
Copy link

Is this supposed to be launchable now? New to this and only tried the 4.24 version.

Plugins/UnrealEnginePython/Source/UnrealEnginePython/Private/Slate/UEPyFMenuBuilder.cpp(2): fatal error C1083: Cannot open include file: 'IAssetTools.h': No such file or directory
Seems like it's preventing me from launching.

I had to remove the IAssetTools.h include from that file.

@boristsr boristsr mentioned this pull request May 7, 2020
Open
AJIADb9
AJIADb9 reviewed May 26, 2020
View reviewed changes
Source/UnrealEnginePython/Private/Slate/UEPyFMenuBuilder.cpp
@@ -1,5 +1,5 @@
#include "UEPyFMenuBuilder.h"

#include "IAssetTools.h"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#if WITH_EDITOR

@HiIAmMoot
Copy link

HiIAmMoot commented Feb 12, 2021 •
edited
Loading

When launching I get this exception:
Unhandled exception at 0x00007FFA99A4DACE (ucrtbase.dll) in UE4Editor.exe: Fatal program exit requested.

It exceptions at line 483 at UnrealEnginePython.cpp

_setmode(_fileno(stdin), O_TEXT); _setmode(_fileno(stdout), O_TEXT); _setmode(_fileno(stderr), O_TEXT);

I'm using anaconda3 as my python base.

EDIT: Seems like it was indeed anaconda, or it was one of my installed modules. Tried with a clean python install and it worked fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJIADb9 AJIADb9 AJIADb9 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@SaxonRah @riandrake @HarryMolina @Adanteh @gschweig-amz @HiIAmMoot @AJIADb9 @slartibaartfast @rdeioris @SIRHAMY