Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): prevent npcs from tick healing non-recoil damage #1402

Merged
merged 5 commits into from
Mar 3, 2025

Conversation

tannerdino
Copy link
Collaborator

@tannerdino tannerdino commented Mar 3, 2025

  • Npc's can no longer tick heal incoming damage, with the exception of ring of recoil damage. However, xp gained and kill credit should still use the capped damage.

From Video:
image

@mark-b5
Copy link
Contributor

mark-b5 commented Mar 3, 2025

Heropoints and xp should still be capped to current hp

@tannerdino
Copy link
Collaborator Author

Heropoints and xp should still be capped to current hp

Good catch

@tannerdino
Copy link
Collaborator Author

Notable change I do here is I only call npc_heropoints if the hit lands. Is this true in osrs? Right now it looks like you'll be placed into the npc's hero index if you do 0 damage?

@Pazaz Pazaz merged commit 4425e2b into 2004Scape:main Mar 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

%com_maxhit should be stored in local var
3 participants